Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19870] PubSubAsReliable test fix #3994

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[19870] PubSubAsReliable test fix #3994

merged 4 commits into from
Nov 13, 2023

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 7, 2023 •
edited by JesusPoderoso
Loading

Description

The PubSubHistory/PubSubHistory.PubSubAsReliableKeepLastWithKeyUnorderedReception consistently fails if it is launched with taskset -c 2 [command] (which makes the test to run in one core). The reason is that the drop data percentage deterministically drop every 1 out of 5 DATA packages sent (User endpoints only, discovery traffic endpoints are not considered, so any change in the discovery settings results in no effect).

The changes let the test_UDPTransportDescriptor percentages to be dynamically updated, and proposes a fix for the test which consists in varying the drop percentage after having received some packets.

Note: The complete launch command is taskset -c 2 ./BlackboxTests_DDS_PIM --gtest_filter=PubSubHistory/PubSubHistory.PubSubAsReliableKeepLastWithKeyUnorderedReception/Transport_PREALLOCATED

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.12.1 milestone Nov 7, 2023
@Mario-DL
Copy link
Member Author

Mario-DL commented Nov 8, 2023

@richiprosima please test windows

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Nov 8, 2023
@JesusPoderoso
Copy link
Contributor

@richiprosima please test windows please test linux

@Mario-DL
Refs #19770: Rev suggestion
ed308a6 
Signed-off-by: Mario Dominguez <[email protected]>
JesusPoderoso
JesusPoderoso approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

1 similar comment
@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 11, 2023
@EduPonz EduPonz merged commit ded6cd6 into master Nov 13, 2023
11 of 14 checks passed
@EduPonz EduPonz deleted the bugfix/test/pubsubasreliable branch November 13, 2023 08:27
@Mario-DL
Copy link
Member Author

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2023
@Mario-DL @mergify
PubSubAsReliable test fix (#3994)
edaca5f 
* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)
This was referenced Nov 13, 2023
Merged
Merged
Merged
@MiguelCompany MiguelCompany mentioned this pull request Nov 14, 2023
Merged
9 tasks
EduPonz pushed a commit that referenced this pull request Dec 1, 2023
@Mario-DL @EduPonz
PubSubAsReliable test fix (#3994)
75596ac 
* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)
MiguelCompany added a commit that referenced this pull request Dec 1, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#4011)
4883ff0 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
EduPonz pushed a commit that referenced this pull request Dec 2, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#3994) (#4010)
cb65fcd 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
EduPonz pushed a commit that referenced this pull request Dec 4, 2023
@Mario-DL @EduPonz
PubSubAsReliable test fix (#3994)
f853648 
* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)
EduPonz pushed a commit that referenced this pull request Dec 11, 2023
@mergify @Mario-DL @MiguelCompany
PubSubAsReliable test fix (#3994) (#4009)
f8cf460 
* PubSubAsReliable test fix  (#3994)

* Refs #19803: Let descriptor percentages be dynamically configured

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: Fix test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19803: address windows warning

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #19770: Rev suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ded6cd6)

* Make `test_UDPv4TransportDescriptor` non-copyable and non-moveable (#4017)

* Make `test_UDPv4TransportDescriptor` non-copyable and default moveable

* Make test_UDPv4TransportDescriptor non-moveable

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @JesusPoderoso @EduPonz