Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19851] Fix missing mandatory attribute check in XML parser struct type #3995

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[19851] Fix missing mandatory attribute check in XML parser struct type #3995

merged 2 commits into from
Nov 13, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Nov 7, 2023 •
edited
Loading

Description

Struct's name attribute is mandatory to be set while configuring types through XML configuration. This PR add a check in XML parser to fail if no name was defined.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Nov 7, 2023
@JesusPoderoso JesusPoderoso added this to the v2.12.1 milestone Nov 7, 2023
@JesusPoderoso JesusPoderoso self-assigned this Nov 7, 2023
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

Mario-DL
Mario-DL requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix ! Just leaving a NIT. We will then order a CI

src/cpp/rtps/xmlparser/XMLDynamicParser.cpp Outdated Show resolved Hide resolved
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

Mario-DL
Mario-DL approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test mac

1 similar comment
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test mac

@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 13, 2023
@EduPonz EduPonz merged commit b10bfe6 into master Nov 13, 2023
9 of 14 checks passed
@EduPonz EduPonz deleted the hotfix/clusterfuzz_struct_types branch November 13, 2023 08:26
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
@JesusPoderoso @mergify
Fix missing mandatory attribute check in XML parser struct type (#3995)
33c97f3 
* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit b10bfe6)

# Conflicts:
#	test/unittest/xmlparser/XMLParserTests.cpp
@mergify mergify bot mentioned this pull request Nov 13, 2023
Closed
@mergify mergify bot mentioned this pull request Nov 13, 2023
Merged
@mergify mergify bot mentioned this pull request Nov 13, 2023
Merged
JesusPoderoso added a commit that referenced this pull request Nov 13, 2023
@JesusPoderoso
Fix missing mandatory attribute check in XML parser struct type (#3995)
6a08b79 
* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit b10bfe6)
EduPonz pushed a commit that referenced this pull request Dec 2, 2023
@JesusPoderoso @EduPonz
Fix missing mandatory attribute check in XML parser struct type (#3995)
0da3dab 
* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit b10bfe6)
MiguelCompany pushed a commit that referenced this pull request Dec 2, 2023
@mergify @JesusPoderoso
Fix missing mandatory attribute check in XML parser struct type (#4008)
b35cad1 
* Fix missing mandatory attribute check in XML parser struct type (#3995)

* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit b10bfe6)

* Refs #198451: Fix conflict

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Jesús Poderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Dec 2, 2023
@mergify @JesusPoderoso
Fix missing mandatory attribute check in XML parser struct type (#3995)…
d0557f9 
… (#4007)

* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit b10bfe6)

Co-authored-by: Jesús Poderoso <[email protected]>
cferreiragonz pushed a commit that referenced this pull request Dec 5, 2023
@JesusPoderoso @cferreiragonz
Fix missing mandatory attribute check in XML parser struct type (#3995)
7e67c58 
* Refs #19851: Fix missing mandatory attribute check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19851: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Dec 11, 2023
@MiguelCompany @JesusPoderoso
Fix missing mandatory attribute check in XML parser struct type (#3995)…
3c4ca45 
… (#4014)

* Refs #19851: Fix missing mandatory attribute check



* Refs #19851: Apply rev suggestions



---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @MiguelCompany @Mario-DL @EduPonz