[21036] Handle errors when setting socket buffer sizes (backport #4760) #4796

MiguelCompany · 2024-05-16T15:29:52Z

Description

This is a manual backport of #4760 where s_minimumSocketBuffer has been deprecated instead of removed.

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

EduPonz

LGTM with green CI

EduPonz · 2024-05-17T11:51:57Z

@Mergifyio rebase

…ending buffer. Signed-off-by: Miguel Company <[email protected]>

… sets also sending buffer. Signed-off-by: Miguel Company <[email protected]>

Signed-off-by: Miguel Company <[email protected]>

This reverts commit ed848e9.

Signed-off-by: Miguel Company <[email protected]>

mergify · 2024-05-17T11:52:16Z

rebase

✅ Branch has been successfully rebased

MiguelCompany · 2024-05-20T07:57:23Z

@Mergifyio backport 2.13.x

mergify · 2024-05-20T07:57:50Z

backport 2.13.x

✅ Backports have been created

#4812 [21036] Handle errors when setting socket buffer sizes (backport #4760) (backport #4796) has been created for branch 2.13.x but encountered conflicts

* Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on CreateInputChannelResource. Signed-off-by: Miguel Company <[email protected]> * Revert "Refs #20972. Applying changes on CreateInputChannelResource." This reverts commit ed848e9. * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 53cd211) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # src/cpp/rtps/transport/UDPv6Transport.cpp # test/blackbox/common/DDSBlackboxTestsListeners.cpp

* Handle errors when setting socket buffer sizes (#4760) (#4796) * Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on CreateInputChannelResource. Signed-off-by: Miguel Company <[email protected]> * Revert "Refs #20972. Applying changes on CreateInputChannelResource." This reverts commit ed848e9. * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 53cd211) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # src/cpp/rtps/transport/UDPv6Transport.cpp # test/blackbox/common/DDSBlackboxTestsListeners.cpp * Refs #21036. Fix conflicts. Signed-off-by: Miguel Company <[email protected]> * Refs #21036. Update for non-backported changes Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>

* Handle errors when setting socket buffer sizes (#4760) (#4796) * Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on CreateInputChannelResource. Signed-off-by: Miguel Company <[email protected]> * Revert "Refs #20972. Applying changes on CreateInputChannelResource." This reverts commit ed848e9. * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 53cd211) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # src/cpp/rtps/transport/UDPv6Transport.cpp # test/blackbox/common/DDSBlackboxTestsListeners.cpp * Refs #21036. Fix conflicts. Signed-off-by: Miguel Company <[email protected]> * Refs #21036. Update for non-backported changes Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 5d1c013) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # test/unittest/transport/TCPv6Tests.cpp # test/unittest/transport/UDPv4Tests.cpp # test/unittest/transport/UDPv6Tests.cpp

… samples (#4187) (#4608) * Handle errors when setting socket buffer sizes (#4760) (#4796) * Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Applying changes on CreateInputChannelResource. Signed-off-by: Miguel Company <[email protected]> * Revert "Refs #20972. Applying changes on CreateInputChannelResource." This reverts commit ed848e9. * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <[email protected]> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 53cd211) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # src/cpp/rtps/transport/UDPv6Transport.cpp # test/blackbox/common/DDSBlackboxTestsListeners.cpp * Refs #21036. Fix conflicts. Signed-off-by: Miguel Company <[email protected]> * Refs #21036. Update for non-backported changes Signed-off-by: Miguel Company <[email protected]> * Fix on_sample_lost notification on best-effort readers for fragmented samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <[email protected]> * Refs #20167. Linters. Signed-off-by: Miguel Company <[email protected]> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <[email protected]> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <[email protected]> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 5ac198e) * Make sample_lost_be_dw_be_dr_fragments test less flaky (#4620) * Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey. Signed-off-by: Miguel Company <[email protected]> * Refs #20692. Uncrustify. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>

MiguelCompany added this to the v2.14.2 milestone May 16, 2024

MiguelCompany force-pushed the bugfix/20972_2.14.x branch from 002a541 to 6e52568 Compare May 16, 2024 16:14

MiguelCompany requested a review from EduPonz May 17, 2024 05:27

github-actions bot added the ci-pending PR which CI is running label May 17, 2024

MiguelCompany changed the title ~~Handle errors when setting socket buffer sizes (backport #4760)~~ [21036] Handle errors when setting socket buffer sizes (backport #4760) May 17, 2024

EduPonz approved these changes May 17, 2024

View reviewed changes

MiguelCompany added 23 commits May 17, 2024 11:52

Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also s…

321e11f

…ending buffer. Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers…

c9ca72a

… sets also sending buffer. Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Improvements in on_sample_lost blackbox tests.

9edea5b

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Move code into new private methods.

010a82c

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Refactor on configure_send_buffer_size.

ff54467

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Refactor on configure_receive_buffer_size.

5f65d7b

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Check user configuration at the beginning of init method.

d66e0cc

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Use maxMessageSize as minimum possible value.

4167268

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket.

9f68775

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Applying changes on CreateInputChannelResource.

f43e217

Signed-off-by: Miguel Company <[email protected]>

Revert "Refs #20972. Applying changes on CreateInputChannelResource."

8a5d438

This reverts commit ed848e9.

Refs #20972. Add helper header with template method.

2713559

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Configure methods return boolean.

de118c7

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Configure methods use new template method.

3f6df39

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. OpenAndBindUnicastOutputSocket uses new template method.

65e654c

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Changes in OpenAndBindInputSocket.

79a26ab

Signed-off-by: Miguel Company <[email protected]>

Refs #20972.Setting options on TCP channels.

8738a37

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Doxygen.

b18bfce

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Check limits of configured sizes.

b456c78

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Add UDP unit tests.

29d35ce

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Add TCP unit tests.

6618edd

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Move checks in TCP to beginning of init.

2388a15

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Refactor for common code in UDP.

2911060

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany added 7 commits May 17, 2024 11:52

Refs #20972. Refactor for common code in TCP.

1609313

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Remove unused constants in UDP tests.

eb0a7f4

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Check final configuration on unit tests.

e98cec8

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Uncrustify.

b75f72b

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Less strict tests.

e1606ac

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Remove s_minimumSocketBuffer from tests.

9b71c83

Signed-off-by: Miguel Company <[email protected]>

Refs #20972. Deprecate s_minimumSocketBuffer.

b534346

Signed-off-by: Miguel Company <[email protected]>

EduPonz force-pushed the bugfix/20972_2.14.x branch from 6e52568 to b534346 Compare May 17, 2024 11:52

EduPonz self-requested a review May 17, 2024 11:52

EduPonz approved these changes May 20, 2024

View reviewed changes

EduPonz merged commit 53cd211 into 2.14.x May 20, 2024
10 of 12 checks passed

EduPonz deleted the bugfix/20972_2.14.x branch May 20, 2024 05:45

mergify bot mentioned this pull request May 20, 2024

[21036] Handle errors when setting socket buffer sizes (backport #4760) (backport #4796) #4812

Merged

11 tasks

mergify bot mentioned this pull request May 27, 2024

[21036] Handle errors when setting socket buffer sizes (backport #4760) (backport #4796) (backport #4812) #4852

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21036] Handle errors when setting socket buffer sizes (backport #4760) #4796

[21036] Handle errors when setting socket buffer sizes (backport #4760) #4796

MiguelCompany commented May 16, 2024 •

edited by EduPonz

Loading

EduPonz left a comment

EduPonz commented May 17, 2024

mergify bot commented May 17, 2024

MiguelCompany commented May 20, 2024

mergify bot commented May 20, 2024 •

edited

Loading

[21036] Handle errors when setting socket buffer sizes (backport #4760) #4796

[21036] Handle errors when setting socket buffer sizes (backport #4760) #4796

Conversation

MiguelCompany commented May 16, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz left a comment

Choose a reason for hiding this comment

EduPonz commented May 17, 2024

mergify bot commented May 17, 2024

✅ Branch has been successfully rebased

MiguelCompany commented May 20, 2024

mergify bot commented May 20, 2024 • edited Loading

✅ Backports have been created

MiguelCompany commented May 16, 2024 •

edited by EduPonz

Loading

mergify bot commented May 20, 2024 •

edited

Loading