Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21638] Be less strict with parameter lengths (backport #5225) #5248

Open
wants to merge 2 commits into
base: 2.10.x
Choose a base branch
from
Open

[21638] Be less strict with parameter lengths (backport #5225) #5248

wants to merge 2 commits into from

Commits on Oct 28, 2024

  1. Be less strict with parameter lengths (#5225) 

    * Refs #21537. Add regression test for interoperability issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Add regression test for big parameters.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Fix builtin deserialization length checks.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Special cases in test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Extend test to full non-custom range.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Extend parameter size to 64K.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21537. Uncrustify.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21638. Fix windows warning.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 7b111f9)

# Conflicts:
#	src/cpp/fastdds/core/policy/ParameterSerializer.hpp
#	test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
    @MiguelCompany
    MiguelCompany committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    41130d6 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    80c002a View commit details
    Browse the repository at this point in the history