Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing IDL oneway operations [21145] #147

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 5, 2024

Description

Currently the parser fails if it encounters a oneway operation. This PR fixes it.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix parsing IDL oneway operations Fix parsing IDL oneway operations [21145] Jun 5, 2024
@MiguelCompany MiguelCompany added this to the v4.0.0 milestone Jul 1, 2024
@MiguelCompany MiguelCompany merged commit 31e6519 into master Jul 3, 2024
1 check passed
@MiguelCompany MiguelCompany deleted the bugfix/21085 branch July 3, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants