Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set runtime check for discovery and p2p protocols #254

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Set runtime check for discovery and p2p protocols #254

merged 2 commits into from
Jun 1, 2021

Conversation

Acuadros95
Copy link
Contributor

No description provided.

@Acuadros95 Acuadros95 requested a review from pablogs9 May 31, 2021 13:51
@Acuadros95
Copy link
Contributor Author

Micro-XRCE-DDS-Agent/include/uxr/agent/utils/ArgumentParser.hpp

Lines 467 to 472 in fa1ca77

#ifdef UAGENT_DISCOVERY_PROFILE
, discovery_("-d", "--discovery", static_cast<uint16_t>(DEFAULT_DISCOVERY_PORT), {}, false)
#endif
#ifdef UAGENT_P2P_PROFILE
, p2p_("-P", "--p2p")
#endif

Should we show an error message if the user tries to configure the discovery/p2p flags with an incompatible transport?

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@Acuadros95 Acuadros95 merged commit fc9564b into develop Jun 1, 2021
@Acuadros95 Acuadros95 deleted the feature/check_p2p branch June 1, 2021 05:58
@Acuadros95 Acuadros95 restored the feature/check_p2p branch June 3, 2021 09:54
@pablogs9 pablogs9 deleted the feature/check_p2p branch June 10, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Acuadros95 @richiprosima @pablogs9