Override domain_id with ROS_DOMAIN_ID provided by the agent #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delihus
changed the title
|
Build status:
|
delihus
force-pushed
the
domain-id-from-env
branch
from
514de9c
to
4722043
Compare
|
Build status:
|
|
Please take a look at the Windows CI Warning |
delihus
force-pushed
the
domain-id-from-env
branch
from
4d88313
to
70cd923
Compare
|
Build status:
|
delihus
force-pushed
the
domain-id-from-env
branch
from
70cd923
to
35840b9
Compare
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
delihus
force-pushed
the
domain-id-from-env
branch
from
82c2782
to
f63e1af
Compare
|
Build status:
|
pablogs9
reviewed
Jul 4, 2023
| @@ -1242,5 +1260,15 @@ bool FastDDSMiddleware::matched_replier_from_bin( | |||
| return rv; | |||
| } | |||
|
|
|||
| int16_t FastDDSMiddleware::get_domain_id_from_env(){ | |||
| int16_t agent_domain_id = 0; | |||
| const char * agent_domain_id_env = std::getenv( "ROS_DOMAIN_ID" ); | |||
There was a problem hiding this comment.
IMO The override of Micro XRCE-DDS Agent shall be ROS 2 agnostic. What about using XRCE_DOMAIN_ID_OVERRIDE?
CC: @Acuadros95
There was a problem hiding this comment.
Then the compose would look like this if you have defined ROS_DOMAIN_ID before.
microros:
image: husarion/micro-ros-agent:humble-overrice-domain-id
network_mode: host
ipc: host
devices:
- ${SERIAL_PORT:?err}
environment:
- SERIAL_PORT
- RMW_IMPLEMENTATION=rmw_fastrtps_cpp
- XRCE_DOMAIN_ID_OVERRIDE=${ROS_DOMAIN_ID}
# - XRCE_DOMAIN_ID_OVERRIDE=2
command: serial -D $SERIAL_PORT serial -b 576000 # -v6Not bad. I can do this. ;)
There was a problem hiding this comment.
I agree with @pablogs9, looks cleaner
Where can I describe the feature? |
Signed-off-by: Jakub Delicat <[email protected]>
|
Build status:
|
Don't worry @delihus, we can do it here https://github.com/eProsima/Micro-XRCE-DDS-docs after the PR is merged |
Acuadros95
approved these changes
Jul 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a need to select
ROS_DOMAIN_IDin firmware without recompiling. Comparing this changes #322 and this PR #331 I prepared overriding client domain id. This change will override the clients domain (only when it is255- safe value due to the smaller domain limit) to theROS_DOMAIN_IDconfigured as an environmental variable in e. g. micro-ros-agent docker container.Tested on Nucleo-L476RG publisher example and ROSbot 2R firmware.
Here are the changes inside firmware husarion/rosbot_ros2_firmware#20.
I prepared prebuilt docker container with these changes
husarion/micro-ros-agent:humble-overrice-domain-id.This is the example compose for ROSbot 2R or any microros serial client:
Best regards,
JD