Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Binary entity creation mode #224

Merged
merged 15 commits into from
Apr 30, 2021
Merged

Add Binary entity creation mode #224

merged 15 commits into from
Apr 30, 2021

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Apr 7, 2021 •
edited
Loading

TODO

  • Fill client API headers
  • Fill client binary creation implementation
  • Design QoS API (see RMW)
  • Desing a message for requester/replier
  • Implement Agent creation in FastDDS middleware
  • Test in general repo
  • Test in Agent unit test
  • Update RMW to bin creation
  • Remove XML/REF option from RMW
  • Shared memory: Update matching engine in client

Extras:

  • Check QoS matching in FastDDS Middleware matched_*_from_bin
  • Implement xrce_obj to qos in FastDDS Middleware
  • Fill XRCE entities to QoS in agent

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 mentioned this pull request Apr 7, 2021
Merged
@pablogs9 pablogs9 marked this pull request as draft April 7, 2021 06:40
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Initial
aaf7028 
Update


Revert "Initial"

This reverts commit bbef97f3599786be2febc15f8e8b474a4006234d.

Initial


Update


Update


Initial
@pablogs9 pablogs9 force-pushed the feature/binary_entity_creation branch from 020a3d2 to aaf7028 Compare April 9, 2021 11:21
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 force-pushed the feature/binary_entity_creation branch from fed8413 to 710bc15 Compare April 29, 2021 06:38
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 marked this pull request as ready for review April 29, 2021 07:18
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 requested review from jamoralp and Acuadros95 and removed request for jamoralp April 30, 2021 08:01
@pablogs9 pablogs9 mentioned this pull request Apr 30, 2021
Merged
4 tasks
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 merged commit 206e7bf into develop Apr 30, 2021
@pablogs9 pablogs9 deleted the feature/binary_entity_creation branch April 30, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogs9 @richiprosima @Acuadros95