Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make emojis.json a ts file so no bad path in type defs #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

revilossor
Copy link

@revilossor revilossor commented Nov 30, 2022

writes 'emojis.ts' instead of 'emojis.json' so that there is no bad path to './emojis.json' in dist/ ( the json is only in src/ )

closes [https://github.com//issues/294] i think - i was seeing the same error in a library project with typescript ( i have a typescript build as a git hook - the rollup build worked fine, guess cos rollup doesnt need to resolve emojis.json in the ts defs )

@arjita-mitra
Copy link

arjita-mitra commented May 10, 2023

@ealush Can we merge this? I am having same issues, my build pipeline keeps failing.

Run set -o pipefail
Error: node_modules/emoji-picker-react/dist/data/emojis.d.ts(1,20): error TS2307: Cannot find module './emojis.json' or its corresponding type declarations.
Error: Process completed with exit code 2.

the json file doesn't exist under dist directory, its only present under src hence the problem. this will prevent me from using the library and our release date is close. Please help me resolve this issue. Note, I can't add skipLibcheck in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants