Skip to content

Commit

Permalink
Removed check on kickofftimearg (flyteorg#388)
Browse files Browse the repository at this point in the history
Signed-off-by: Prafulla Mahindrakar <[email protected]>
  • Loading branch information
pmahindrakar-oss authored Apr 5, 2022
1 parent 96d7276 commit 426f46b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions pkg/manager/impl/launch_plan_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ func isScheduleEmpty(launchPlanSpec admin.LaunchPlanSpec) bool {
if schedule.GetCronSchedule() != nil && len(schedule.GetCronSchedule().Schedule) != 0 {
return false
}
if len(schedule.GetKickoffTimeInputArg()) != 0 {
return false
}
if len(schedule.GetCronExpression()) != 0 {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/manager/impl/launch_plan_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,6 @@ func TestIsScheduleEmpty(t *testing.T) {
},
},
}
assert.False(t, isScheduleEmpty(sp))
assert.True(t, isScheduleEmpty(sp))
})
}

0 comments on commit 426f46b

Please sign in to comment.