Add Standardized pull request template (flyteorg#74)

boilerplate/lyft/golang_support_tools/tools.go

@@ -3,8 +3,8 @@
 package tools
 
 import (
-	_ "github.com/alvaroloes/enumer"
 	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
 	_ "github.com/lyft/flytestdlib/cli/pflags"
 	_ "github.com/vektra/mockery/cmd/mockery"
+	_ "github.com/alvaroloes/enumer"
 )

boilerplate/lyft/pull_request_template/Readme.rst

@@ -0,0 +1,8 @@
+Pull Request Template
+~~~~~~~~~~~~~~~~~~~~~
+
+Provides a Pull Request template.
+
+**To Enable:**
+
+Add ``lyft/golang_test_targets`` to your ``boilerplate/update.cfg`` file.

boilerplate/lyft/pull_request_template/pull_request_template.md

@@ -0,0 +1,26 @@
+# TL;DR
+_Please replace this text with a description of what this PR accomplishes._
+
+## Type
+ - [ ] Bug Fix
+ - [ ] Feature
+ - [ ] Plugin
+
+## Are all requirements met?
+
+ - [ ] Code completed
+ - [ ] Smoke tested
+ - [ ] Unit tests added
+ - [ ] Code documentation added
+ - [ ] Any pending items have an associated Issue
+
+## Complete description
+ _How did you fix the bug, make the feature etc. Link to any design docs etc_
+
+## Tracking Issue
+https://github.com/lyft/flyte/issues/<number>
+
+## Follow-up issue
+_NA_
+OR
+_https://github.com/lyft/flyte/issues/<number>_

boilerplate/lyft/pull_request_template/update.sh

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+
+# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
+# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY:
+# 
+# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst
+
+set -e
+
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
+
+cp ${DIR}/pull_request_template.md ${DIR}/../../../pull_request_template.md

boilerplate/update.cfg

@@ -2,3 +2,4 @@ lyft/docker_build
 lyft/golang_test_targets
 lyft/golang_dockerfile
 lyft/golang_support_tools
+lyft/pull_request_template

pull_request_template.md

@@ -0,0 +1,26 @@
+# TL;DR
+_Please replace this text with a description of what this PR accomplishes._
+
+## Type
+ - [ ] Bug Fix
+ - [ ] Feature
+ - [ ] Plugin
+
+## Are all requirements met?
+
+ - [ ] Code completed
+ - [ ] Smoke tested
+ - [ ] Unit tests added
+ - [ ] Code documentation added
+ - [ ] Any pending items have an associated Issue
+
+## Complete description
+ _How did you fix the bug, make the feature etc. Link to any design docs etc_
+
+## Tracking Issue
+https://github.com/lyft/flyte/issues/<number>
+
+## Follow-up issue
+_NA_
+OR
+_https://github.com/lyft/flyte/issues/<number>_