Parametrize functional test (flyteorg#55)

Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario · Mar 3, 2022 · c710b61 · c710b61
1 parent 8d7b1a5
commit c710b61
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/boilerplate-repo/boilerplate/flyte/end2end/Makefile b/boilerplate-repo/boilerplate/flyte/end2end/Makefile
@@ -5,8 +5,9 @@
 
 .PHONY: end2end_execute
 end2end_execute:
-	./boilerplate/flyte/end2end/end2end.sh
-
+	# TODO: These arguments could come from environment variables
+	./boilerplate/flyte/end2end/end2end.sh ./boilerplate/flyte/end2end/functional-test.config --return_non_zero_on_failure
+
 .PHONY: k8s_integration_execute
 k8s_integration_execute:
-	echo "pass"
+	echo "pass"
diff --git a/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh b/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh
@@ -6,8 +6,11 @@
 # TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst
 set -e
 
+CONFIG_FILE=$1; shift
+EXTRA_FLAGS=( "$@" )
+
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
 
 LATEST_VERSION=$(curl --silent "https://api.github.com/repos/flyteorg/flytesnacks/releases/latest" | jq -r .tag_name)
 
-FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE python ./boilerplate/flyte/end2end/run-tests.py $LATEST_VERSION P0,P1 ./boilerplate/flyte/end2end/functional-test.config --return_non_zero_on_failure
+FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE python ./boilerplate/flyte/end2end/run-tests.py $LATEST_VERSION P0,P1 $CONFIG_FILE ${EXTRA_FLAGS[@]}