Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add board Pimoroni Pico Plus 2 #2415

Merged

Conversation

SamHalvoe
Copy link
Contributor

Hi, I have added the Pimoroni Pico Plus 2 board.
This is the first board (and contribution) I have added. I hope I haven't done anything wrong.
Best Regards
Sam Halvoe

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@earlephilhower
Copy link
Owner

I think you forgot to check in your modified makeboards.py

@SamHalvoe
Copy link
Contributor Author

I checked in my modified makeboards.py and added the board to the readme. Also updated pins_arduino.h (added PSRAM_CS among others)

@earlephilhower earlephilhower merged commit 902f709 into earlephilhower:master Sep 5, 2024
20 checks passed
@earlephilhower
Copy link
Owner

Thx!

@SamHalvoe SamHalvoe deleted the pimoroni-pico-plus-2 branch September 12, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants