Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows env caching in GH #328

Closed
wants to merge 1 commit into from
Closed

Fix windows env caching in GH #328

wants to merge 1 commit into from

Conversation

gutzbenj
Copy link
Member

@gutzbenj gutzbenj commented Jan 23, 2021

Try to make GHA also apply appropriate caching when building within Windows environments.

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #328 (1e7043c) into main (2cbae78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files          54       54           
  Lines        2783     2783           
  Branches      284      284           
=======================================
  Hits         2517     2517           
  Misses        211      211           
  Partials       55       55           
Flag Coverage Δ
unittests 90.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbae78...1e7043c. Read the comment docs.

@gutzbenj gutzbenj force-pushed the windows-env-caching branch 20 times, most recently from 3d6e992 to e1dcb0e Compare January 23, 2021 18:57
@amotl
Copy link
Member

amotl commented Jan 23, 2021

Hi Benjamin,

thanks a stack for working on this! The GitHub Action recipe conceived by @sondrelg on behalf of @snok actually looks like it is well prepared for being able to help us on getting the caching for Poetry environments on Windows right [1]. Kudos to @sondrelg and good luck to you!

With kind regards,
Andreas.

[1] https://github.com/snok/install-poetry#windows

.github/workflows/tests.yml Outdated Show resolved Hide resolved
with:
virtualenvs-create: true
virtualenvs-in-project: true
virtualenvs-path: .venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark: virtualenv-path is not set within the canonical example for Windows at https://github.com/snok/install-poetry#windows.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@gutzbenj gutzbenj force-pushed the windows-env-caching branch 5 times, most recently from 1819503 to 2ac931a Compare January 24, 2021 00:38
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thanks @gutzbenj and @sondrelg!

@gutzbenj gutzbenj closed this Jan 24, 2021
@amotl amotl deleted the windows-env-caching branch January 24, 2021 19:16
@amotl amotl restored the windows-env-caching branch January 24, 2021 19:17
@gutzbenj gutzbenj deleted the windows-env-caching branch January 26, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants