-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows env caching in GH #328
Conversation
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 90.44% 90.44%
=======================================
Files 54 54
Lines 2783 2783
Branches 284 284
=======================================
Hits 2517 2517
Misses 211 211
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
3d6e992
to
e1dcb0e
Compare
Hi Benjamin, thanks a stack for working on this! The GitHub Action recipe conceived by @sondrelg on behalf of @snok actually looks like it is well prepared for being able to help us on getting the caching for Poetry environments on Windows right [1]. Kudos to @sondrelg and good luck to you! With kind regards, |
.github/workflows/tests.yml
Outdated
with: | ||
virtualenvs-create: true | ||
virtualenvs-in-project: true | ||
virtualenvs-path: .venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a remark: virtualenv-path
is not set within the canonical example for Windows at https://github.com/snok/install-poetry#windows.
1819503
to
2ac931a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c874a42
to
e4f5a43
Compare
e4f5a43
to
ba39ea3
Compare
107eae4
to
a02307c
Compare
a02307c
to
1e7043c
Compare
Try to make GHA also apply appropriate caching when building within Windows environments.