avoid CMake fiddling with the RPATHs injected by EasyBuild via --rpath #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2016
|
@wpoely86 please review? |
wpoely86
approved these changes
Nov 13, 2016
| self.lib_exts = [] | ||
|
|
||
| def configure_step(self, *args, **kwargs): | ||
| """Configure build using 'make config' (only for recent versions (>= v5)).""" | ||
|
|
||
| if LooseVersion(self.version) >= LooseVersion("5"): | ||
|
|
||
| if build_option('rpath'): | ||
| # patch Makefile to tell CMake not to wipe the RPATHs we inject... | ||
| apply_regex_substitutions('Makefile', [(r'^(CONFIG_FLAGS\s*=\s*)', r'\1-DCMAKE_SKIP_RPATH=ON ')]) |
There was a problem hiding this comment.
no space between \1 and -D...?
There was a problem hiding this comment.
Should be there already, but doesn't hurt to make sure, you're right, I'll add it.
|
Thanks for the review @wpoely86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
-DCMAKE_SKIP_RPATH=ONwhen using--rpathis required to avoid that CMake strips all RPATHs from the built binaries/libraries before actually installing them (which it does by default, urgh).Required to get METIS to build in conjunction with
--rpath(cfr. easybuilders/easybuild-framework#1942).