Make the Rosetta EasyBlock work in --module-only mode #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbez
force-pushed
the
patch-rosetta-cxx-module-only
branch
from
0dd634e
to
bd55c3f
Compare
Previously the sanity check would fail since None was inserted into the paths of the files to be checked (rather than the actual compiler name). Fixes easybuilders#1072.
tobbez
force-pushed
the
patch-rosetta-cxx-module-only
branch
from
bd55c3f
to
da79f3a
Compare
|
lgtm, thanks for looking into this @tobbez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the sanity check would fail since None was inserted into the
paths of the files to be checked (rather than the actual compiler name).