Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkinter easyblock - WIP #1118

Merged
merged 1 commit into from
May 23, 2017
Merged

tkinter easyblock - WIP #1118

merged 1 commit into from
May 23, 2017

Conversation

verdurin
Copy link
Member

This is a prerequisite for Python-2.7.13 and the separate Tkinter easyconfig.

I was unsure how much of the existing easyblock to remove, given that we're building the whole thing and deleting most of it.

Very open to cleaner ways of doing this.

@boegel boegel added this to the 3.2.0 milestone Feb 28, 2017
@boegel
Copy link
Member

boegel commented Feb 28, 2017

@verdurin Can you also open PRs for the Python without Tkinter + the Tkinter easyconfig?

I indeed think that this easyblock can be cleaned up quite a bit. Also, it should be named EB_Tkinter (there is no other Tkinter afaict)?

@verdurin
Copy link
Member Author

verdurin commented Feb 28, 2017

New PR easybuilders/easybuild-easyconfigs#4225 for the easyconfigs depending on this.

@boegel boegel modified the milestones: 3.2.0, 3.1.1 Mar 1, 2017
@boegel
Copy link
Member

boegel commented Apr 6, 2017

@wpoely86 do you have time to give this a thorough review or help @verdurin with cleaning this up?

@boegel boegel modified the milestones: 3.2.0, 3.3.0 May 2, 2017
@wpoely86 wpoely86 mentioned this pull request May 21, 2017
@boegel boegel merged commit 36d2a50 into easybuilders:develop May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants