add support for detecting auto-downloaded dependencies in PythonPackage easyblock #1377
Conversation
| @@ -178,17 +178,18 @@ def extra_options(extra_vars=None): | |||
| if extra_vars is None: | |||
| extra_vars = {} | |||
| extra_vars.update({ | |||
| 'unpack_sources': [True, "Unpack sources prior to build/install", CUSTOM], | |||
| 'buildcmd': ['build', "Command to pass to setup.py to build the extension", CUSTOM], | |||
| 'download_dep_fail': [False, "Fail if downloaded dependencies are detected", CUSTOM], | |||
There was a problem hiding this comment.
Set to False for backward-compatibility, but we should consider switching this to True by default for EasyBuild v4.0.0.
Problem is that we'll need to fix quite a bit of easyconfigs...
We could try to enforce a policy where new easyconfigs for Python packages include download_dep_fail = True?
|
@wpoely86 please review? |
|
Following @akesandgren's suggestion during this week's conf call to enhance this such that it holds off reporting an error until all extensions have been installed (which helps in dealing with problems in one go), I think we should move the download check to the We already postpone reporting sanity check failures for extensions (in general) until all extensions are installed, so we can ride on that for this too. There's one downside though... There's currently no support for including a custom message to the error message that is produced when the sanity check fails. Hence, I think we should make some changes to framework first to improve error reporting for failing sanity checks for extensions... |
…Package generic easyblock + leverage general 'exts_download_dep_fail' easyconfig parameter
|
@akesandgren suggestion is now implemented, but it depends on two changes in EasyBuild framework (see updated description) |
|
The framework PRs on which this depends have been merged, so this is good to go? |
|
My tests did not show any issue. Merging |
edit: easybuilders/easybuild-framework#2493 + depends on easybuilders/easybuild-framework#2494