Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extension filter for Perl modules (WIP) #1449

Closed
wants to merge 1 commit into from

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 3, 2018

Current approach of checking whether Perl modules are installed fails to catch missing dependencies, cfr.:

$ perldoc -lm 'GD::Graph'
/prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/site_perl/5.26.1/GD/Graph.pm
$ echo $?
0

vs

$ perl -e 'require GD::Graph'
Can't locate GD.pm in @INC (you may need to install the GD module) (@INC contains: /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/site_perl/5.26.1/x86_64-linux-thread-multi /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/site_perl/5.26.1 /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/5.26.1/x86_64-linux-thread-multi /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/5.26.1) at /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/site_perl/5.26.1/GD/Graph.pm line 38.
BEGIN failed--compilation aborted at /prefix/software/Perl/5.26.1-GCCcore-6.4.0/lib/perl5/site_perl/5.26.1/GD/Graph.pm line 38.
Compilation failed in require at -e line 1.
$ echo $?
2

I made this WIP for now because fixing this impacts all Perl easyconfigs, and maybe other easyconfigs in which Perl extensions are involved, since the extension filter is also used during the sanity check...

Accompanying fixes will be required in these easyconfigs to avoid installations suddenly failing to complete.

@damianam
Copy link
Member

@boegel ping? How are the fixes in the easyconfigs repo coming along? I see just 2 references here, fixing 4 files.

@boegel boegel modified the milestones: 3.7.0, next release Sep 18, 2018
@boegel
Copy link
Member Author

boegel commented Sep 18, 2018

@damianam To be honest, I'm not sure... I would have to take a closer look, since this also affects the PerlModule easyblock.

@boegel boegel modified the milestones: 3.7.1, next release Oct 10, 2018
@boegel boegel modified the milestones: 3.8.0, 3.8.1 Dec 12, 2018
@boegel boegel removed this from the 3.8.1 milestone Jan 19, 2019
@boegel boegel added this to the 3.x milestone May 16, 2019
@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
@branfosj
Copy link
Member

branfosj commented Apr 4, 2022

closing - we'll make this change with #2699

@branfosj branfosj closed this Apr 4, 2022
@boegel boegel deleted the fix_perl_ext_test branch April 25, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants