Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't set $BOOST_ROOT when only installing Boost Python bindings #1495

Merged
merged 1 commit into from
Sep 7, 2018
Merged

don't set $BOOST_ROOT when only installing Boost Python bindings #1495

merged 1 commit into from
Sep 7, 2018

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 31, 2018

fix on top of changes made in #1484

@boegel boegel added the bug fix label Aug 31, 2018
@boegel boegel added this to the 3.7.0 milestone Aug 31, 2018
migueldiascosta
migueldiascosta approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta merged commit 1d6d0af into easybuilders:develop Sep 7, 2018
@boegel boegel deleted the boost_python_BOOST_ROOT branch September 7, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @migueldiascosta