Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting of $RUNPARALLEL in HDF5 easyblock #2250

Merged
merged 1 commit into from
Dec 1, 2020
Merged

fix setting of $RUNPARALLEL in HDF5 easyblock #2250

merged 1 commit into from
Dec 1, 2020

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Nov 24, 2020 •
edited
Loading

  • the MPI tests require at least 3 mpi tasks
  • the old \$\${NPROC... caused errors when expanding RUNPARALLEL

@akesandgren
hdf5.py: Fix setting of RUNPARALLEL.
e31acd1 
 - the MPI tests require at least 3 mpi tasks
 - the old \$\${NPROC... caused errors when expanding RUNPARALLEL
@akesandgren akesandgren added this to the 4.3.2 (next release) milestone Nov 24, 2020
@boegel boegel changed the title hdf5.py: Fix setting of RUNPARALLEL. fix setting of RUNPARALLEL in h5py easyblock Dec 1, 2020
@boegel boegel changed the title fix setting of RUNPARALLEL in h5py easyblock fix setting of $RUNPARALLEL in h5py easyblock Dec 1, 2020
@boegel
Copy link
Member

boegel commented Dec 1, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS h5py-2.10.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS h5py-2.10.0-foss-2020a-Python-3.8.2.eb
  • SUCCESS h5py-2.10.0-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS h5py-2.10.0-intel-2019b-Python-3.7.4.eb
  • SUCCESS h5py-2.10.0-intel-2020a-Python-3.8.2.eb
  • SUCCESS h5py-2.10.0-intelcuda-2019b-Python-3.7.4.eb
  • SUCCESS h5py-2.8.0-foss-2018b-Python-2.7.15.eb
  • SUCCESS h5py-2.8.0-foss-2018b-Python-3.6.6.eb
  • SUCCESS h5py-2.8.0-fosscuda-2018b-Python-2.7.15.eb
  • SUCCESS h5py-2.8.0-fosscuda-2018b-Python-3.6.6.eb
  • SUCCESS h5py-2.9.0-foss-2019a.eb
  • SUCCESS h5py-2.9.0-fosscuda-2019a.eb

Build succeeded for 12 out of 12 (12 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/87c980b6b161ce868a7285a51909b230 for a full test report.

boegel
boegel approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 5ef5da5 into easybuilders:develop Dec 1, 2020
@akesandgren akesandgren deleted the fix_RUNPARALLEL_in_hdf5 branch December 2, 2020 12:57
This was referenced Dec 3, 2020
Closed
Open
@boegel boegel changed the title fix setting of $RUNPARALLEL in h5py easyblock fix setting of $RUNPARALLEL in HDF5 easyblock Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@akesandgren @boegel