Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance Amber easyblock to support installing Amber via CMake #2445

Merged
merged 7 commits into from
Jun 16, 2021
Merged

enhance Amber easyblock to support installing Amber via CMake #2445

merged 7 commits into from
Jun 16, 2021

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented May 29, 2021 •
edited
Loading

(created using eb --new-pr)

Add support to build Amber 20:

  • Amber 20 uses CMake (older versions use configuremake)
  • Amber 20 can be built in a build directory (older versions required to be built in install directory)
  • We've only built foss and fosscuda versions
  • The CUDA version does some building during the install step
  • If Amber detects a current install then it causes the new build to fail - hence making sure to delete the installdir at the start
  • The tests are flaky - we failed to find any number of cores for the parallel tests that allowed them all to pass in the same time and the Amber manual suggests that this is normal

@branfosj branfosj added this to the 4.x milestone May 29, 2021
@branfosj branfosj mentioned this pull request May 29, 2021
Merged
2 tasks
@smoors smoors mentioned this pull request Jun 7, 2021
Merged
akesandgren
akesandgren requested changes Jun 11, 2021
View reviewed changes
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
akesandgren
akesandgren requested changes Jun 16, 2021
View reviewed changes
easybuild/easyblocks/a/amber.py Outdated Show resolved Hide resolved
akesandgren
akesandgren approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Test report in easybuilders/easybuild-easyconfigs#12985

akesandgren
akesandgren approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren modified the milestones: 4.x, next release (4.4.1) Jun 16, 2021
@akesandgren
Copy link
Contributor

Going in, thanks @branfosj!

@akesandgren akesandgren merged commit 0095d48 into easybuilders:develop Jun 16, 2021
@branfosj branfosj deleted the 20210529094152_new_pr_kCZWvWTLVF branch June 16, 2021 17:34
@boegel boegel changed the title Add CMake support for Amber 20 enhance Amber easyblock to support installing Amber via CMake Jun 23, 2021
@boegel boegel mentioned this pull request Sep 17, 2021
Closed
@boegel boegel mentioned this pull request Oct 20, 2021
Merged
@branfosj branfosj mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
enhancement update
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @akesandgren