Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance ConfigureMake generic easyblock to add support for building multiple build targets #2449

Merged
merged 3 commits into from
Jun 11, 2021
Merged

enhance ConfigureMake generic easyblock to add support for building multiple build targets #2449

merged 3 commits into from
Jun 11, 2021

Conversation

mboisson
Copy link
Contributor

No description provided.

@mboisson
Copy link
Contributor Author

Here is an example of EasyConfig which would use this feature:
https://github.com/ComputeCanada/easybuild-easyconfigs/blob/computecanada-main/easybuild/easyconfigs/a/Arioc/Arioc-1.43-gcccorecuda-2020a.eb

@boegel boegel changed the title added support for building multiple targets enhance ConfigureMake generic easyblock to add support for building multiple build targets Jun 1, 2021
boegel
boegel previously requested changes Jun 1, 2021
View reviewed changes
easybuild/easyblocks/generic/configuremake.py Outdated Show resolved Hide resolved
easybuild/easyblocks/generic/configuremake.py Outdated Show resolved Hide resolved
easybuild/easyblocks/generic/configuremake.py Show resolved Hide resolved
@boegel boegel added this to the release after 4.4.0 milestone Jun 1, 2021
smoors
smoors approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the easyconfig linked to (using gcccuda), works nicely

@smoors smoors dismissed boegel’s stale review June 11, 2021 14:52

requested changes addressed

@smoors
Copy link
Contributor

smoors commented Jun 11, 2021

Going in, thanks @mboisson!

@smoors smoors merged commit 27b9ebc into easybuilders:develop Jun 11, 2021
branfosj added a commit to branfosj/easybuild-easyblocks that referenced this pull request Jun 17, 2021
@branfosj
changes to build_targets (easybuilders#2449) break Clang and LLVM builds
8a40467
This was referenced Jun 17, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

@boegel boegel boegel left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mboisson @smoors @boegel