Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance Java easyblock to define %(jdkarch)s template #2472

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jun 14, 2021

Add a custom template for the architecture names used by OpenJDK installers.

Disclaimer: this code is shamelessly copy pasted from the cudnn easyblock.

@lexming
Copy link
Contributor Author

lexming commented Jun 14, 2021

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS Java-1.8.0_281.eb
  • SUCCESS Java-11.0.2.eb
  • SUCCESS Java-13.0.2.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/63ab1cd53e04e2868414af122071ad00 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Jun 15, 2021

Real test can be found in easybuilders/easybuild-easyconfigs#13141 (comment)

@boegel boegel added this to the next release (4.4.1) milestone Jun 23, 2021
@boegel boegel changed the title add jdkarch to java easyblock enhance Java easyblock to define %(jdkarch)s template Jun 23, 2021
@boegel
Copy link
Member

boegel commented Jun 23, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Java-11.0.2.eb
  • SUCCESS Java-13.0.2.eb
  • SUCCESS Java-1.8.0_281.eb
  • SUCCESS Java-11.eb
  • SUCCESS Java-13.eb
  • SUCCESS Java-1.8.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3533.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f7e267e369b8a7ea7e6a7b530f13b803 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 24a18d7 into easybuilders:develop Jun 23, 2021
@lexming lexming deleted the java-arch branch June 24, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants