Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance GCC easyblock to make sure that system GCC provides LTO support, and disable LTO when building MPFR if not #2498

Merged
merged 1 commit into from
Jun 30, 2021
Merged

enhance GCC easyblock to make sure that system GCC provides LTO support, and disable LTO when building MPFR if not #2498

merged 1 commit into from
Jun 30, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 29, 2021

Fix for failing GCCcore build because system compiler doesn't support -flto:

checking if Link Time Optimisation flag '-flto' is supported...... no
configure: error: Link Time Optimisation flag '-flto' is not supported.

@boegel boegel added bug fix EESSI Related to EESSI project labels Jun 29, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jun 29, 2021
@boegel
Copy link
Member Author

boegel commented Jun 29, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS GCCcore-10.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/4aaabbc178757caa8047ee245363c3fe for a full test report.

migueldiascosta
migueldiascosta approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit da5a3e6 into easybuilders:develop Jun 30, 2021
@boegel boegel deleted the gcc_mpfr_lto_fix branch June 30, 2021 06:57
@boegel boegel changed the title make sure that system GCC provides LTO support, and disable LTO when building MPFR if not enhance GCC easyblock to make sure that system GCC provides LTO support, and disable LTO when building MPFR if not Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @migueldiascosta