Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct GTK+ version for OpenCV based on dependencies #2520

Merged
merged 1 commit into from
Jul 17, 2021
Merged

use correct GTK+ version for OpenCV based on dependencies #2520

merged 1 commit into from
Jul 17, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 16, 2021 •
edited
Loading

(created using eb --new-pr)

This avoids failed installations if system GTK3 is found

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS ant-1.10.5-Java-1.8.eb
  • SUCCESS OpenCV-4.0.1-foss-2018b-Python-3.6.6.eb
  • SUCCESS OpenCV-3.4.5-foss-2018b-Python-2.7.15.eb

Build succeeded for 3 out of 3 (2 easyconfigs in total)
taurusi6608.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/1780fbbfc4b0673cda33ad2404220086 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS OpenCV-4.2.0-fosscuda-2019b-Python-3.7.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusi6605.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/42774235db94d2da7c9ac5aef15420a5 for a full test report.

@Flamefire
Copy link
Contributor Author

OpenCV-3.4.5-foss-2018b-Python-2.7.15.eb and OpenCV-4.0.1-foss-2018b-Python-3.6.6.eb show -DWITH_GTK_2_X=ON

OpenCV-4.2.0-fosscuda-2019b-Python-3.7.4.eb doesn't show the flag as expected

@migueldiascosta migueldiascosta added this to the next release (4.4.2?) milestone Jul 17, 2021
migueldiascosta
migueldiascosta approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit 3039d0c into easybuilders:develop Jul 17, 2021
@Flamefire Flamefire deleted the 20210716125104_new_pr_kwqqUSDIuR branch July 19, 2021 07:02
@boegel boegel changed the title Use correct GTK+ for OpenCV use correct GTK+ version for OpenCV based on dependencies Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @migueldiascosta