Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't grep for specific version in --version output of Intel compiler commands for versions 2022.x #2644

Merged
merged 1 commit into from
Dec 23, 2021
Merged

don't grep for specific version in --version output of Intel compiler commands for versions 2022.x #2644

merged 1 commit into from
Dec 23, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 23, 2021

(created using eb --new-pr)

@boegel boegel mentioned this pull request Dec 23, 2021
Merged
@boegel boegel added the update label Dec 23, 2021
@boegel boegel modified the milestones: 4.x, next release (4.5.2?) Dec 23, 2021
@robert-mijakovic
Copy link

ifx has also 2022.0.0

@boegel
Copy link
Member Author

boegel commented Dec 23, 2021

ifx has also 2022.0.0

With this change I'm just running ifx --version, but I'm not checking the output at all.
Since --version also prints the location of the installation for some commands, there will always be a hit for %(version)s, so the check is kind of silly anyway...

@boegel
Copy link
Member Author

boegel commented Dec 23, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS intel-compilers-2021.1.2.eb
  • SUCCESS intel-compilers-2021.2.0.eb
  • SUCCESS intel-compilers-2021.3.0.eb
  • SUCCESS intel-compilers-2021.4.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3513.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/c054574a38b7a6cda094173147263181 for a full test report.

bedroge
bedroge approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bedroge bedroge merged commit 7daeca2 into easybuilders:develop Dec 23, 2021
@boegel boegel deleted the 20211223142950_new_pr_intel_compilers branch December 23, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedroge bedroge bedroge approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@boegel @robert-mijakovic @bedroge