-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New EasyBlocks for Spparks and Stitch #2948
base: develop
Are you sure you want to change the base?
Conversation
easybuild/easyblocks/s/spparks.py
Outdated
DEFAULT_TEST_CMD = 'make' | ||
|
||
|
||
class EB_spparks(EasyBlock): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps inherit from the MakeCp
generic easyblock to avoid reimplementing some of its functionality?
@boegel I did an single PR for both easyblocks because the two softwares are linked together: up to date the Stitch library is developed for use with the SPPARKS software. But I can also separate them into two PRs if it makes it easier to review/testing |
@Mooon No need for two separate PRs, but looking into the suggested changes would be nice. |
(created using
eb --new-pr
)