Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EasyBlocks for Spparks and Stitch #2948

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Mooon
Copy link

@Mooon Mooon commented Jun 6, 2023

@boegel
Copy link
Member

boegel commented Jun 7, 2023

@Mooon Both easyblocks are not small, so maybe it would help to have separate PRs for them, to easy to review/testing process.
Unless there's a reason they're bundled together?

cc @casparvl

DEFAULT_TEST_CMD = 'make'


class EB_spparks(EasyBlock):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps inherit from the MakeCp generic easyblock to avoid reimplementing some of its functionality?

@Mooon
Copy link
Author

Mooon commented Jun 7, 2023

@boegel I did an single PR for both easyblocks because the two softwares are linked together: up to date the Stitch library is developed for use with the SPPARKS software. But I can also separate them into two PRs if it makes it easier to review/testing

@boegel
Copy link
Member

boegel commented Dec 6, 2023

@boegel I did an single PR for both easyblocks because the two softwares are linked together: up to date the Stitch library is developed for use with the SPPARKS software. But I can also separate them into two PRs if it makes it easier to review/testing

@Mooon No need for two separate PRs, but looking into the suggested changes would be nice.

@boegel boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024
@Mooon
Copy link
Author

Mooon commented Apr 17, 2024

Hi @boegel @jfgrimm,
I modified the scripts according to the received feedback. Please let me know if any further action is needed from my side to review this pr.

@boegel boegel modified the milestones: 4.9.2, release after 4.9.2 Jun 6, 2024
@boegel boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants