Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use checkMCR.sh to determine if we have the correct MCR for FreeSurfer #2962

Merged
merged 1 commit into from
Jul 13, 2023
Merged

use checkMCR.sh to determine if we have the correct MCR for FreeSurfer #2962

merged 1 commit into from
Jul 13, 2023

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 13, 2023 •
edited
Loading

(created using eb --new-pr)

see discussion in easybuilders/easybuild-easyconfigs#18300

@branfosj branfosj added this to the next release (4.8.1?) milestone Jul 13, 2023
@branfosj branfosj mentioned this pull request Jul 13, 2023
Closed
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 1 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/c9016ac894f990f4022920cf630acbbd for a full test report.

@branfosj
Copy link
Member Author

^ is as expected. FreeSurfer-7.2.0-centos8_x86_64.eb passes, as we are using the correct MCR version and FreeSurfer-7.3.2-centos8_x86_64.eb fails as we need to update the MCR version.

This was referenced Jul 13, 2023
Closed
Merged
@branfosj
Copy link
Member Author

See easybuilders/easybuild-easyconfigs#18303 (comment) for a build report using this PR with the updated FreeSurfer 7.3.2 and 7.4.0 easyconfigs.

@migueldiascosta
Copy link
Member

migueldiascosta commented Jul 13, 2023 •
edited
Loading

this is great since it will enable us to know if/when the MCR dependency version is silently changed again

migueldiascosta
migueldiascosta approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @branfosj!

@migueldiascosta migueldiascosta merged commit fa94684 into easybuilders:develop Jul 13, 2023
46 checks passed
@branfosj branfosj deleted the 20230713103148_new_pr_freesurfer branch July 14, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @migueldiascosta