Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sanity check for OpenFOAM's wmake to make sure it finds the compiler commands #3328

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add a sanity check for OpenFOAM's wmake to make sure it finds the compiler commands #3328

merged 1 commit into from
Jun 7, 2024

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 13, 2024

No description provided.

@ocaisa ocaisa mentioned this pull request May 13, 2024
Merged
@ocaisa ocaisa changed the title Add a sanity check for OpenFOAM's to make sure it finds the compiler commands Add a sanity check for OpenFOAM's wmake to make sure it finds the compiler commands May 13, 2024
ocaisa
ocaisa commented May 13, 2024
View reviewed changes
easybuild/easyblocks/o/openfoam.py
@@ -486,6 +486,11 @@ def sanity_check_step(self):
test_foammonitor = "! foamMonitor -h 2>&1 | grep 'not installed'"
custom_commands.append(' && '.join([load_openfoam_env, test_foammonitor]))

if self.is_dot_com and self.looseversion >= LooseVersion("2012"):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always have worked, but I could be conservative and only actually check for later versions of OpenFOAM.com

@ocaisa ocaisa mentioned this pull request May 13, 2024
Closed
@ocaisa
Copy link
Member Author

ocaisa commented May 13, 2024 •
edited
Loading

@boegelbot please test @ jsc-zen3
EB_ARGS="OpenFOAM-v2112-foss-2022a.eb OpenFOAM-v2206-foss-2022a.eb OpenFOAM-v2106-foss-2021a.eb"

@boegelbot
Copy link

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3328 EB_ARGS="OpenFOAM-v2112-foss-2022a.eb OpenFOAM-v2206-foss-2022a.eb OpenFOAM-v2106-foss-2021a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3328 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4113

Test results coming soon (I hope)...

- notification for comment with ID 2108061430 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2112-foss-2022a.eb
  • SUCCESS OpenFOAM-v2206-foss-2022a.eb
  • SUCCESS CGAL-4.14.3-gompi-2021a.eb
  • SUCCESS ParaView-5.9.1-foss-2021a-mpi.eb
  • SUCCESS libcerf-1.17-GCCcore-10.3.0.eb
  • SUCCESS Lua-5.4.3-GCCcore-10.3.0.eb
  • SUCCESS gnuplot-5.4.2-GCCcore-10.3.0.eb
  • SUCCESS OpenFOAM-v2106-foss-2021a.eb

Build succeeded for 8 out of 8 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a3203f3b75ee9ae870e254d8376d7ea3 for a full test report.

@boegel boegel added this to the release after 4.9.1 milestone May 21, 2024
@boegel
Copy link
Member

boegel commented Jun 6, 2024

Also tested with OpenFOAM-v2012-foss-2020a.eb and OpenFOAM-v2106-foss-2021a.eb using --sanity-check-only, works as intended.

@boegel
Copy link
Member

boegel commented Jun 6, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 4 (4 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/aab8ac20f8ac23230e1656bec04f8347 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Jun 6, 2024

@boegel Those builds failed as they are the ones fixed in easybuilders/easybuild-easyconfigs#20517

@ocaisa
Copy link
Member Author

ocaisa commented Jun 6, 2024

(which was the motivation for this PR)

@boegel
Copy link
Member

boegel commented Jun 7, 2024

Indeed, works fine with the modified patch in easybuilders/easybuild-easyconfigs#20517, so good to go, thanks @ocaisa!

@boegel boegel merged commit ff6b0f5 into easybuilders:develop Jun 7, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ocaisa @boegelbot @boegel