Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PythonPackage easyblock to allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set + move temporary pip folder into build dir #3374

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

Flamefire
Copy link
Contributor

Using the tempdir usually works but the contents of that folder are usually build artifacts.
As they might become rather large use the builddir for $XDG_CACHE_HOME instead.
As an alternative os.path.abspath(build_path()) could be used but that might clash with parallel installations.

The user using EasyBuild might have $PIP_REQUIRE_VIRTUALENV set which will fail the installation of PythonPackages with

ERROR: Could not find an activated virtualenv (required).

So disable this.
pip 20.2.3+ seems to require false as the value instead of any other value (including the empty string)

Using the tempdir usually works but the contents of that folder are
usually build artifacts.
As they might become rather large use the builddir instead.
As an alternative `os.path.abspath(build_path())` could be used but that
might clash with parallel installations.
The user using EasyBuild might have $PIP_REQUIRE_VIRTUALENV set which
will fail the installation of PythonPackages with
> ERROR: Could not find an activated virtualenv (required).

So disable this. pip 20.2.3+ seems to require `false` as the value
instead of any other value (including the empty string)
@boegel boegel changed the title allow installation of python packages with $PIP_REQUIRE_VIRTUALENV set and move temporary pip folder into build dir allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set and move temporary pip folder into build dir Jul 3, 2024
@boegel boegel changed the title allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set and move temporary pip folder into build dir allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set and move temporary pip folder into build dir Jul 3, 2024
@boegel boegel changed the title allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set and move temporary pip folder into build dir update PythonPackage easyblock to allow installation of Python packages with $PIP_REQUIRE_VIRTUALENV set + move temporary pip folder into build dir Jul 3, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 3, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jul 3, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS matplotlib-3.8.2-gfbf-2023b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3158.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/a8414a50350aa1562e768e8edb044e0d for a full test report.

@boegel boegel merged commit 3d0a948 into easybuilders:develop Jul 3, 2024
41 checks passed
@Flamefire Flamefire deleted the pythonpackage branch July 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants