Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT easyblock to support sysroot #3467

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update ROOT easyblock to support sysroot #3467

merged 1 commit into from
Oct 3, 2024

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Oct 2, 2024

May help with EESSI/software-layer#769

@ocaisa ocaisa added the EESSI Related to EESSI project label Oct 2, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Oct 3, 2024

Got a test report?

@Micket
Copy link
Contributor

Micket commented Oct 3, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS GL2PS-1.4.2-GCCcore-12.3.0.eb
  • SUCCESS ROOT-6.30.06-foss-2023a.eb

Build succeeded for 2 out of 2 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/0cbefe6f00f723e1d6a64e90e2cef9e7 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Oct 3, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/pr3467 ROOT-6.30.06-foss-2023a.eb ROOT-6.26.10-foss-2022b.eb ROOT-6.26.06-foss-2022a.eb ROOT-6.24.06-foss-2021b.eb"

@boegelbot
Copy link

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=3467 EB_ARGS="--installpath /tmp/pr3467 ROOT-6.30.06-foss-2023a.eb ROOT-6.26.10-foss-2022b.eb ROOT-6.26.06-foss-2022a.eb ROOT-6.24.06-foss-2021b.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3467 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14379

Test results coming soon (I hope)...

- notification for comment with ID 2390903681 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Oct 3, 2024

Successful build that uses this PR in EESSI/software-layer#769 (comment) (where sysroot is actually used)

@Micket Micket added this to the release after 4.9.4 milestone Oct 3, 2024
@Micket Micket merged commit bd7fe7e into develop Oct 3, 2024
81 checks passed
@branfosj branfosj deleted the ocaisa-patch-1 branch October 3, 2024 09:35
@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS ROOT-6.30.06-foss-2023a.eb
  • SUCCESS ROOT-6.26.10-foss-2022b.eb
  • SUCCESS ROOT-6.26.06-foss-2022a.eb
  • SUCCESS ROOT-6.24.06-foss-2021b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6d589b8202f7d0d3f0a79d0488a13e41 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EESSI Related to EESSI project enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants