Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition of $MKLROOT, should be set to 'mkl' subdir of install dir #576

Merged
merged 2 commits into from
Apr 9, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 10, 2015

bug mentioned by @klust

in practice, this doesn't make too much of a difference for use of eb itself (w.r.t. use of $MKLROOT in easyblocks/easyconfigs), but the path is incorrect w.r.t. MKL Link Advisor

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/838/
Test PASSed.

@boegel
Copy link
Member Author

boegel commented Mar 10, 2015

@wpoely86: thoughts on this?

@wpoely86
Copy link
Member

Well, I hope it doesn't break anything. It shouldn't but we've seen stranger shit.

@boegel
Copy link
Member Author

boegel commented Mar 11, 2015

breaking stuff early in dev is fine ;)

I'll take a look where $MKLROOT is being (obviously) used, and retest those builds on top of this.

@boegel boegel mentioned this pull request Mar 11, 2015
8 tasks
@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/898/
Test PASSed.

@boegel
Copy link
Member Author

boegel commented Apr 9, 2015

merged via #590

@boegel boegel deleted the fix_mklroot branch April 9, 2015 17:11
boegel added a commit to boegel/easybuild-easyblocks that referenced this pull request Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants