Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TensorFlow 2.1.0 easyconfigs to provide more dependencies via EasyBuild #11109

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 13, 2020

This is basically a test run. It makes the installation faster and smaller and avoids some downloads at build time.

This approach will be required for TF 2.3.0 and I'll add PRs for the other 2.x ECs once this is merged

Reason why it is required is the TF 2.3 bundles cURL but builds it with Bazel side-stepping the (correct) configuration from cURL and introducing a bug on some systems making parts of TF unusable: tensorflow/tensorflow#40065 (comment)

@Flamefire
Copy link
Contributor Author

@boegel Whats going on with the tests? I didn't add neither hwloc nor ICU

@Flamefire Flamefire force-pushed the tensorflow_syslibs branch 4 times, most recently from fad4551 to 3b6d8ab Compare August 17, 2020 14:37
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 18, 2020
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 3 out of 5 (5 easyconfigs in this PR)
taurusi5018.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/5cb1a2273ad5422115b2db1b55190799 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2020
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • also stick to hwloc 1.x in foss easyconfig

@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2020
@boegel boegel changed the title [TensorFlow 2.1.0] Use system libs update TensorFlow 2.1.0 easyconfigs to provide more dependencies via EasyBuild Sep 4, 2020
@boegel
Copy link
Member

boegel commented Sep 4, 2020

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2117"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11109 EB_ARGS="--include-easyblocks-from-pr 2117" /apps/slurm/default/bin/sbatch --job-name test_PR_11109 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5257

Test results coming soon (I hope)...

- notification for comment with ID 687114655 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
taurusml24 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/5718090247881e2ea7707f1e3e6dec33 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3404.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/ff4737a4818fc66d2af5a080b54aaa88 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3106.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/6ebd5b6de8b4089942268534c3f19d4e for a full test report.

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
FAILED
Build succeeded for 7 out of 9 (5 easyconfigs in this PR)
node3300.joltik.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/e9d830106381a7b54475758b41617c91 for a full test report.

edit: failed because of old double-conversion installation (see fix in #9659), will re-submit test

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
taurusi5186.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8b24a73ad25d361a97ebe5a720ec452d for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5493bd67e169c13dd654efbb4629cf5e for a full test report.

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
FAILED
Build succeeded for 4 out of 6 (5 easyconfigs in this PR)
node2411.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/2fb41216076a30e81e72c7c106455281 for a full test report.

edit: ignore this one, not enough memory available (gcc: internal compiler error: Bus error signal terminated program cc1plus)

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3309.joltik.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/5938623f83e0e896a69e3b12437e3acb for a full test report.

@boegel
Copy link
Member

boegel commented Sep 4, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3415.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/8b1db00b08f61e9552006ec0d18ea2f6 for a full test report.

edit: tested on top of easybuilders/easybuild-easyblocks#2163

@boegel
Copy link
Member

boegel commented Sep 5, 2020

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2163"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11109 EB_ARGS="--include-easyblocks-from-pr 2163" /apps/slurm/default/bin/sbatch --job-name test_PR_11109 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5260

Test results coming soon (I hope)...

- notification for comment with ID 687555263 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1acb3029ad4bc23e5483b7977393d686 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 6, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 4eec88a into easybuilders:develop Sep 6, 2020
@Flamefire Flamefire deleted the tensorflow_syslibs branch September 7, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants