Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add include/node to $CPATH in nodejs easyconfigs + tweak V8 easyconfigs accordingly #11845

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 8, 2020

Because nodejs installations include OpenSSL header files, which causes trouble (see #11663 + jeroen/openssl#84).

Other easyconfigs that depend on nodejs don't need to be fixed because of these changes (I'll confirm that in the test report).

…s installations include OpenSSL header files) + tweak V8 easyconfigs accordingly
@boegel
Copy link
Member Author

boegel commented Dec 8, 2020

Test report by @boegel
SUCCESS
Build succeeded for 14 out of 14 (14 easyconfigs in total)
node3159.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/dbce9f81a593cd2cd8f2a2a1ce238582 for a full test report.

@boegel
Copy link
Member Author

boegel commented Dec 8, 2020

Test report by @boegel
SUCCESS
Build succeeded for 14 out of 14 (14 easyconfigs in total)
node2610.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/148e1dda2ac8b1de73bd929dc204331c for a full test report.

Micket
Micket previously approved these changes Dec 8, 2020
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Dec 8, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/ed31ed111710a92ddfd24623adb0b0a4 for a full test report.

@lexming
Copy link
Contributor

lexming commented Dec 8, 2020

Test report by @lexming
FAILED
Build succeeded for 8 out of 10 (10 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/e163b1dbd47aadb35ac1116d2cadf574 for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My failed test with V8-3.2.0-foss-2019b-R-3.6.2.eb is due to yet another checksum change in CRAN

checksums = [
    ('f575e07c6fefbc53a96e90bbb41ffdf67794cca797661eb97a6f52348ae20d7c',
     'd2e9b8eb0e9cec76a5c3a8725f7cd50a53ac0d98d0c1ec69d2a943132a2d3eb6'),
]

@lexming
Copy link
Contributor

lexming commented Dec 8, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/26452fbb819f495c9b1a742dd779bff8 for a full test report.

@boegel
Copy link
Member Author

boegel commented Dec 8, 2020

@boegelbot please test @ generoso
EB_ARGS="nodejs-10.15.1-foss-2018b.eb nodejs-10.15.3-GCCcore-8.2.0.eb nodejs-12.16.1-GCCcore-7.3.0.eb nodejs-12.16.1-GCCcore-8.3.0.eb nodejs-12.16.1-GCCcore-9.3.0.eb nodejs-12.19.0-GCCcore-10.2.0.eb V8-2.3-foss-2019a-R-3.6.0.eb V8-3.2.0-foss-2019b-R-3.6.2.eb"
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11845 EB_ARGS="nodejs-10.15.1-foss-2018b.eb nodejs-10.15.3-GCCcore-8.2.0.eb nodejs-12.16.1-GCCcore-7.3.0.eb nodejs-12.16.1-GCCcore-8.3.0.eb nodejs-12.16.1-GCCcore-9.3.0.eb nodejs-12.19.0-GCCcore-10.2.0.eb V8-2.3-foss-2019a-R-3.6.0.eb V8-3.2.0-foss-2019b-R-3.6.2.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_11845 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12263

Test results coming soon (I hope)...

- notification for comment with ID 741031374 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3d336ae100b0c9272e1f28dd51518f55 for a full test report.

@boegel
Copy link
Member Author

boegel commented Dec 9, 2020

@boegelbot please test @ generoso
EB_ARGS="V8-3.2.0-foss-2019b-R-3.6.2.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11845 EB_ARGS="V8-3.2.0-foss-2019b-R-3.6.2.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_11845 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12264

Test results coming soon (I hope)...

- notification for comment with ID 741634012 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/73d093bd47d33c110a58d0d5232124ee for a full test report.

@lexming
Copy link
Contributor

lexming commented Dec 9, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6a7d496ac831d9237ff8ccc796fabc2d for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Dec 9, 2020

Going in, thanks @boegel !

@lexming lexming merged commit 4e21dea into easybuilders:develop Dec 9, 2020
@boegel boegel deleted the nodejs_CPATH branch December 9, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants