Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix uniq operation in TensorFlow 2.4.1 #13181

Merged

Conversation

Flamefire
Copy link
Contributor

(created using eb --new-pr)

@Micket
Copy link
Contributor

Micket commented Jun 16, 2021

I think the patch is missing.

Any comments on the patch that was removed?

@Micket Micket added the bug fix label Jun 16, 2021
@Flamefire
Copy link
Contributor Author

Thanks, added. The new patch fixes the actual bug, the old patch did only disable the tests which ran into the bug

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurussmp8 - Linux RHEL 7.7, x86_64, Intel(R) Xeon(R) Platinum 8276M CPU @ 2.20GHz (cascadelake), Python 2.7.5
See https://gist.github.com/31fb22ef0876f80cfade644662706c3b for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Jun 16, 2021

Just to check, was this unique to 2019b?

@Micket
Copy link
Contributor

Micket commented Jun 16, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13181 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13181 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17472

Test results coming soon (I hope)...

- notification for comment with ID 862489720 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket Micket added this to the next release (4.4.1) milestone Jun 16, 2021
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b14ca8c1f1e92389b438753d061aebe3 for a full test report.

@Flamefire
Copy link
Contributor Author

Just to check, was this unique to 2019b?

This was the only one where it occured before. With GCC 9+ the issue at least disappeared. I added the same patch to TF 2.5 (new) though.

@Micket
Copy link
Contributor

Micket commented Jun 17, 2021

Going in, thanks @Flamefire!

@Micket Micket merged commit f5dff8d into easybuilders:develop Jun 17, 2021
@Flamefire Flamefire deleted the 20210616145847_new_pr_TensorFlow241 branch June 17, 2021 14:54
@boegel boegel changed the title Fix uniq operation in TensorFlow 2.4.1 add patch to fix uniq operation in TensorFlow 2.4.1 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants