-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch to fix uniq operation in TensorFlow 2.4.1 #13181
add patch to fix uniq operation in TensorFlow 2.4.1 #13181
Conversation
I think the patch is missing. Any comments on the patch that was removed? |
Thanks, added. The new patch fixes the actual bug, the old patch did only disable the tests which ran into the bug |
Test report by @Flamefire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just to check, was this unique to 2019b? |
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 862489720 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
This was the only one where it occured before. With GCC 9+ the issue at least disappeared. I added the same patch to TF 2.5 (new) though. |
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)