Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*/2018b] add patch to fix building Qt5 v5.10.1 against newer glibc #13730

Merged
merged 2 commits into from
Aug 22, 2021

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 13, 2021

@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 13, 2021
@branfosj branfosj changed the title Patch to fix building Qt5.10.1 against newer qlibc Patch to fix building Qt5.10.1 against newer glibc Aug 13, 2021
@branfosj branfosj marked this pull request as draft August 13, 2021 10:05
@branfosj branfosj marked this pull request as ready for review August 21, 2021 10:02
@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/70c2c611792249248c00a4445284c1c6 for a full test report.

@branfosj
Copy link
Member Author

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=13730 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13730 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18176

Test results coming soon (I hope)...

- notification for comment with ID 903109853 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 39 out of 39 (2 easyconfigs in total)
bber0501u03a.bb2.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4a06c3a605036b4d7486ee8423519d40 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 6 out of 12 (3 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/127b2f47454891fcdc0742232af0d715 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 21, 2021

Test report by @boegel
FAILED
Build succeeded for 14 out of 15 (3 easyconfigs in total)
node3133.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5d24e655ee7816016ab675328b50c6c5 for a full test report.

@branfosj
Copy link
Member Author

So, this fixes the build issue for Qt5 5.10.1 foss and fosscuda versions. There are more issues with intel / 2018b. I do not have that available to test / debug.

@boegel
Copy link
Member

boegel commented Aug 22, 2021

See #8003 w.r.t. the failing build with intel/2018b.

We never backported the binutils patch to binutils/2.30-GCCcore-7.3.0 used there, so no surprise the issue still stands.

I won't let that block this PR though, the effort required to fix that problem is probably no longer worth it...

@boegel boegel changed the title Patch to fix building Qt5.10.1 against newer glibc [*/2018b] add patch to fix building Qt5.10.1 against newer glibc Aug 22, 2021
@boegel boegel merged commit 203dcf8 into easybuilders:develop Aug 22, 2021
@branfosj branfosj deleted the 20210813103120_new_pr_Qt55101 branch August 22, 2021 09:27
@boegel boegel changed the title [*/2018b] add patch to fix building Qt5.10.1 against newer glibc [*/2018b] add patch to fix building Qt5 v5.10.1 against newer glibc Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants