-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[GCCcore/10.3.0] ROCm v4.3.1 w/ Python 3.9.5 #14156
{tools}[GCCcore/10.3.0] ROCm v4.3.1 w/ Python 3.9.5 #14156
Conversation
@nordmoen: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1344816148
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
|
||
name = 'ROCm' | ||
version = '4.3.1' | ||
versionsuffix = '-amd' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the suffix is not necessary; this is always AMD?
|
||
# Same build order as AOMP | ||
# https://github.com/ROCm-Developer-Tools/aomp/blob/aomp-dev/bin/build_aomp.sh#L98 | ||
components = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure a mega bundle is the way forward. It's going to be very very painful to build test and maintain like that. I would suggest splitting these out as separate packages and perhaps have ROCm depend on them. This would allow partial progress (in both building, and developing the packages). I tried packaging some of these for Julia a while back, and I'm certain at least some of these can just be built standalone and work just like any library.
Closing in favor of #14327 |
(created using
eb --new-pr
)