Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use %(arch)s template to avoid hardcoding x86_64 in recent XML-LibXML easyconfigs #14655

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 4, 2022

(created using eb --new-pr)

@boegel boegel added the bug fix label Jan 4, 2022
@boegel boegel added this to the next release (4.5.2?) milestone Jan 4, 2022
@boegel
Copy link
Member Author

boegel commented Jan 4, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14655 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14655 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7640

Test results coming soon (I hope)...

- notification for comment with ID 1005092084 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Jan 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild2.novalocal - Linux centos stream 8, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/e22d6c13b5d6583d5487786c55942f11 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bce0d07aaffe2511cee7e346a2d1f058 for a full test report.

@boegel boegel requested a review from branfosj January 4, 2022 19:52
@boegel
Copy link
Member Author

boegel commented Jan 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
fair-mastodon-c6g-2xlarge-0002 - Linux rocky linux 8.5, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/fa92d2d39e367ef6540d2998076032a0 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

branfosj commented Jan 5, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/6ccba434fa541eb23f7d4e79d497fb18 for a full test report.

@branfosj
Copy link
Member

branfosj commented Jan 5, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0305u03a.bear.cluster - Linux RHEL 8.5, POWER, 8335-GTX (power9le), 1 x NVIDIA Tesla V100-SXM2-16GB, 470.57.02, Python 3.6.8
See https://gist.github.com/09ed398dcec76d4c86b4fc14280fbf4d for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

branfosj commented Jan 5, 2022

Going in, thanks @boegel!

@branfosj branfosj merged commit 392999b into easybuilders:develop Jan 5, 2022
@boegel boegel deleted the 20220104195649_new_pr_XML-LibXML20205 branch January 5, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants