-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure libffi 3.4.2 with --disable-exec-static-tramp to prevent segfaults #15086
Conversation
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @generoso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for linking the relevant threads. From what I see there, this indeed looks like the right 'workaround' for now. I'll run one final test at generoso, and if that succeeds (as I expect it will), I'll merge it.
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1062033093 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @jhgoebbert! |
Some projects like gobject-introspection use ffi_closure_alloc() as a way to allocate executable memory.
The new exec static tramp in libffi 3.4 interferes with it and therefor must be disabled - or it can result in segfaults.
libffi/libffi#647
This is currently the only solution like it is also done in conda:
conda-forge/libffi-feedstock#39
"Interesting" is this comment: libffi/libffi#647 (comment)
we can do the 3.4 release and distros can initially build with --disable-exec-static-tramp