Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure libffi 3.4.2 with --disable-exec-static-tramp to prevent segfaults #15086

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

jhgoebbert
Copy link
Contributor

@jhgoebbert jhgoebbert commented Mar 7, 2022

Some projects like gobject-introspection use ffi_closure_alloc() as a way to allocate executable memory.
The new exec static tramp in libffi 3.4 interferes with it and therefor must be disabled - or it can result in segfaults.
libffi/libffi#647

This is currently the only solution like it is also done in conda:
conda-forge/libffi-feedstock#39

"Interesting" is this comment: libffi/libffi#647 (comment)
we can do the 3.4 release and distros can initially build with --disable-exec-static-tramp

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Mar 8, 2022
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
skylake-alma8-eb - Linux AlmaLinux 8.5, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.8
See https://gist.github.com/b6f5a449f163b4dc0e99cdcd527dc99e for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
zen2-ubuntu-eb - Linux Ubuntu 22.04, x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.2
See https://gist.github.com/049c588634d1a981fb9d76d244c4bc33 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.6.8
See https://gist.github.com/f56ba65f29d475f85ca5155e4b8dc58f for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrc0437 - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), 4 x NVIDIA NVIDIA A100-SXM4-40GB, 470.82.01, Python 3.6.8
See https://gist.github.com/0148f7c62a5bd85b04fd2b3c59196c8d for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Mar 8, 2022

@boegelbot please test @generoso

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking the relevant threads. From what I see there, this indeed looks like the right 'workaround' for now. I'll run one final test at generoso, and if that succeeds (as I expect it will), I'll merge it.

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=15086 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15086 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8230

Test results coming soon (I hope)...

- notification for comment with ID 1062033093 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0653ebc1601401d0d9d612d98f6d28eb for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Mar 8, 2022

Going in, thanks @jhgoebbert!

@casparvl casparvl merged commit f84195e into easybuilders:develop Mar 8, 2022
@boegel boegel modified the milestones: 4.x, next release (4.5.4) Mar 29, 2022
@boegel boegel changed the title libffi 3.4.2 - disable-exec-static-tramp configure libffi 3.4.2 with --disable-exec-static-tramp to prevent segfaults Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants