Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[foss/2020b,intel/2020b] matplotlib v3.5.1 w/ Python 3.8.6 #15095

Merged
merged 3 commits into from
Mar 13, 2022

Conversation

kosl
Copy link
Contributor

@kosl kosl commented Mar 8, 2022

(created using eb --new-pr)

casparvl
casparvl previously approved these changes Mar 11, 2022
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=15095 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15095 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8266

Test results coming soon (I hope)...

- notification for comment with ID 1065418098 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, maybe was a bit early to approve, let's wait for the actual test result :) But EasyConfig looks good to me now :)

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/35ec4eb70722797d10c5feecfe0c03ae for a full test report.

@casparvl casparvl dismissed their stale review March 11, 2022 19:35

Should have waited for the test...

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matplotlib needs Qhull as a dependency

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=15095 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15095 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8268

Test results coming soon (I hope)...

- notification for comment with ID 1065493784 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/153112eb01841dcb44c1af58a9fe62fb for a full test report.

@kosl
Copy link
Contributor Author

kosl commented Mar 11, 2022

All good now.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 53 out of 53 (2 easyconfigs in total)
software1.lisa.surfsara.nl - Linux debian 10.11, x86_64, Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz, Python 2.7.16
See https://gist.github.com/07cbfa8ff013c638af89320de64d88fe for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Mar 13, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 13, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/39999e10c5be1536c07e9ec7ed785c10 for a full test report.

@boegel boegel added the update label Mar 13, 2022
@boegel boegel added this to the next release (4.5.4?) milestone Mar 13, 2022
@boegel boegel dismissed casparvl’s stale review March 13, 2022 09:34

requested changes made

@boegel
Copy link
Member

boegel commented Mar 13, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2671.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/22c623457f114536bf63aef2907b68ea for a full test report.

@boegel
Copy link
Member

boegel commented Mar 13, 2022

Going in, thanks @kosl!

@boegel boegel merged commit 60d928f into easybuilders:develop Mar 13, 2022
@kosl kosl deleted the 20220308215214_new_pr_matplotlib351 branch March 14, 2022 13:03
@Flamefire
Copy link
Contributor

Just found this as there is/was already a matplotlib 3.3.3 for this toolchain: #11835

Seemingly the 3.3.3 is now used in most ECs for 2020b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants