Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hwloc dependency to tbb v2021.4.0 #15294

Merged

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Apr 18, 2022

(created using eb --new-pr)

@jfgrimm jfgrimm added this to the 4.x milestone Apr 18, 2022
@jfgrimm
Copy link
Member Author

jfgrimm commented Apr 18, 2022

assuming old versions also affected, will need to double-check hwloc version requirements

@jfgrimm
Copy link
Member Author

jfgrimm commented Apr 18, 2022

Test report by @jfgrimm
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
node133.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/e542dbb7fbb29b7540f406f5485ad882 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.5.5?) Apr 19, 2022
@boegel
Copy link
Member

boegel commented Apr 19, 2022

@jfgrimm Salmon failed with error: cannot find -lzstd, but that has nothing to do with the change being made here, I think?

@jfgrimm
Copy link
Member Author

jfgrimm commented Apr 23, 2022

@jfgrimm Salmon failed with error: cannot find -lzstd, but that has nothing to do with the change being made here, I think?

yeah I clearly overlooked that in the Salmon log.
Nonetheless, we're not building the TBBBind library at all in the current configuration unless the OS supplies a suitable hwloc, so this is still meaningful (and e.g. Salmon does check for it)

@boegel boegel changed the title Add hwloc dependency to recent tbb add hwloc dependency to recent tbb easyconfigs Apr 27, 2022
@boegel boegel changed the title add hwloc dependency to recent tbb easyconfigs add hwloc dependency to easyconfig for tbb v2021.4.0 May 25, 2022
@boegel
Copy link
Member

boegel commented May 25, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15294 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15294 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8574

Test results coming soon (I hope)...

- notification for comment with ID 1136820822 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b9674e12e25057c3bc5c397193c942bf for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15294 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15294 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1236

Test results coming soon (I hope)...

- notification for comment with ID 1137861182 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f833242da1582852f23b0c9e62b5d438 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 30, 2022

Going in, thanks @jfgrimm!

@boegel boegel merged commit 6283a7c into easybuilders:develop May 30, 2022
@boegel boegel changed the title add hwloc dependency to easyconfig for tbb v2021.4.0 add hwloc dependency to tbb v2021.4.0 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants