{geo}[gompi/2021b] GOTM v6.0.3, FABM v1.0.3, Fortran-YAML v20210420, flexout v20220209 #15837
Conversation
…20220209-gompi-2021b.eb, FABM-1.0.3-GCC-11.2.0.eb, GOTM-6.0.3-gompi-2021b.eb, GOTM-6.0.3-gompi-2021b-stim.eb and patches: flexout-20220209_use_eb_deps.patch, GOTM-6.0.3_use_eb_deps.patch, GOTM-6.0.3_use_gotm_stim_driver.patch
lexming
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
@boegelbot: please test @ generoso |
|
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1181681711 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
|
||
| github_account = 'BoldingBruggeman' | ||
| source_urls = [GITHUB_LOWER_SOURCE] | ||
| sources = ['%s.tar.gz' % local_commit] |
There was a problem hiding this comment.
I prefer this for unversioned downloads
sources = [{'download_filename': '%s.tar.gz' % local_commit, 'filename': SOURCE_TAR_GZ}]
that way the downloaded filename has a more clear relation to the naming of the easyconfig.
| homepage = 'https://github.com/BoldingBruggeman/fortran-yaml' | ||
| description = "Lightweight YAML parser written in object-oriented Fortran." | ||
|
|
||
| toolchain = {'name': 'GCCcore', 'version': '11.2.0'} |
There was a problem hiding this comment.
Since this is Fortran and it's using fortran modules it must live under GCC, not GCCcore.
The Fortran modules are not shareable between Intel and GCC.
Thus also drop the binutils dep
| ('netCDF-Fortran', '4.5.3'), | ||
| ] | ||
|
|
||
| configopts = '-DBUILD_SHARED_LIBS=ON -DNetCDF_INCLUDE_DIRS=$EBROOTNETCDFMINFORTRAN/include' |
There was a problem hiding this comment.
Use
build_shared_libs = True
instead of -DBUILD_SHARED_LIBS=ON
| - endif() | ||
| - add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/extern/fortran-yaml" "${CMAKE_CURRENT_BINARY_DIR}/extern/yaml") | ||
| - set_property(TARGET yaml PROPERTY FOLDER flexout) | ||
| + include_directories(SYSTEM "$ENV{EBROOTFORTRANMINYAML}/include") |
There was a problem hiding this comment.
Should not really be necessary to use include_dir... here, it's automatically included by the CMake easyblock through CPATHS
I.e. It should work if you just drop the whole check but you'll need to verify it.
| ('netCDF-Fortran', '4.5.3'), | ||
| ] | ||
|
|
||
| configopts = '-DBUILD_SHARED_LIBS=ON ' |
There was a problem hiding this comment.
Use build_shared_libs = True instead
| ('netCDF-Fortran', '4.5.3'), | ||
| ] | ||
|
|
||
| configopts = '-DBUILD_SHARED_LIBS=ON ' |
There was a problem hiding this comment.
Use build_shared_libs = True instead
| +include_directories(SYSTEM | ||
| + "$ENV{EBROOTFLEXOUT}/include" | ||
| + "$ENV{EBROOTFORTRANMINYAML}/include" | ||
| + "$ENV{EBROOTNETCDFMINFORTRAN}/include" | ||
| +) |
There was a problem hiding this comment.
Should not be needed, but please verify
(created using
eb --new-pr)GOTM v6.0.3 plus its dependencies.
The variant of GOTM with STIM requires building both packages at the same time due to a circular dependency:
gotm_stim_driver.modfrom STIMsettings.modfrom GOTM to build the driverSo I made a single easyconfig pulling the sources of both and using a
versionsuffixto differentiate this build from the regular non-STIM one.