Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename hyperopt to Hyperopt, to be consistent with existing Hyperopt easyconfigs #16697

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Nov 21, 2022

We have easyconfigs for Hyperopt with both names Hyperopt and hyperopt. Consolidate names on Hyperopt.

@lexming
Copy link
Contributor Author

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16697 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16697 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9608

Test results coming soon (I hope)...

- notification for comment with ID 1322024047 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 3 (3 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d939b2cba90c45f3e5907a1c171e2454 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 23, 2022

@lexming Tests failed, looks like we have a missing CMake build dep?

Please install CMake and all required dependencies first

edit: the actual problem here is that the Intel license server was down:

Error: A license for Comp-CL is not available now

@boegel
Copy link
Member

boegel commented Dec 7, 2022

checksum problem for cell2location is fixed in #16819

@lexming
Copy link
Contributor Author

lexming commented Dec 8, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16697 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16697 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9723

Test results coming soon (I hope)...

- notification for comment with ID 1342861529 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0ad74f1ad343570688115fe1cbc8e23e for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 8, 2022

@boegel thanks for the input, this is ready now

@boegel boegel changed the title rename hyperopt to Hyperopt rename hyperopt to Hyperopt, to be consistent with existing Hyperopt easyconfigs Dec 9, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 9, 2022

Going in, thanks @lexming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants