Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove appending of $__EGL_VENDOR_LIBRARY_DIRS in recent Mesa easyconfigs, since Mesa easyblock now appends to it #18630

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

lcniel
Copy link
Contributor

@lcniel lcniel commented Aug 23, 2023

(created using eb --new-pr)

Related to easybuilders/easybuild-easyblocks#2985

@Micket
Copy link
Contributor

Micket commented Aug 23, 2023

For everyones information, @lcniel made these changes on my request as this improves EGL support using nvidia drivers from the OS.

@Micket
Copy link
Contributor

Micket commented Aug 25, 2023

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2985
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/d866ae9ac981e11e6337887e594506a5 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 25, 2023

I think we would be ready to test this build on generoso and jcs-zen2 with
EB_ARGS="--include-easyblocks-from-pr 2985 Mesa-23.1.4-GCCcore-12.3.0.eb Mesa-22.2.4-GCCcore-12.2.0.eb Mesa-22.0.3-GCCcore-11.3.0.eb Mesa-21.1.7-GCCcore-11.2.0.eb Mesa-21.1.1-GCCcore-10.3.0.eb Mesa-20.2.1-GCCcore-10.2.0.eb"
If someone else consider this good to go.

@boegel
Copy link
Member

boegel commented Sep 5, 2023

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2985"

@boegel boegel changed the title Remove EGL vendor dir prepend due to move to EasyBlock remove appending of $__EGL_VENDOR_LIBRARY_DIRS in recent Mesa easyconfigs, since Mesa easyblock now appends to it Sep 5, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18630 EB_ARGS="--include-easyblocks-from-pr 2985" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18630 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11647

Test results coming soon (I hope)...

- notification for comment with ID 1707018424 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Sep 5, 2023

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2985
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/2e9fee4de43b681a4b7a5246873492e9 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2985
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6171b2d03f7b7bed1fd2cc4d61366343 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 5, 2023

Going in, thanks @lcniel!

@boegel boegel merged commit fbcf891 into easybuilders:develop Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants