Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies and configure flags of GnuTLS 3.7.x #19070

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Oct 24, 2023

(created using eb --new-pr)

The GnuTLS builds could pick up system libraries instead of EasyBuild ones leading to failures later on, see e.g. #18288

It might also not pick up an EasyBuild dependency, like libidn.

Use --with- and --without- flags when available to enable/disable the dependencies.

Also add the missing pkgconf dependency and use libidn2 instead of the (ignored) libidn, see https://github.com/gnutls/gnutls/blob/3.7.2/configure.ac#L615

Closes #18288

@sassy-crick
Copy link
Collaborator

Test report by @sassy-crick
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
hp - Linux Debian GNU/Linux 11, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.9.2
See https://gist.github.com/sassy-crick/bd1629fe9cbf356b57b5f810a89490e2 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (3 easyconfigs in total)
taurusml2 - Linux RHEL 7.6, POWER, 8335-GTX, 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/Flamefire/c5139fc77b9640372e7629be9253e1a1 for a full test report.

@sassy-crick
Copy link
Collaborator

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@sassy-crick: Request for testing this PR well received on login1

PR test command 'EB_PR=19070 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19070 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12047

Test results coming soon (I hope)...

- notification for comment with ID 1777370089 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/100c096a420e743143caa41a15f2c412 for a full test report.

@Flamefire
Copy link
Contributor Author

@sassy-crick Any update?

@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3026"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19070 EB_ARGS="--include-easyblocks-from-pr 3026" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19070 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12996

Test results coming soon (I hope)...

- notification for comment with ID 1971317059 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3026
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/da560b4461ad6f78112d2f32fc5e803d for a full test report.

@ocaisa ocaisa added this to the release after 4.9.0 milestone Feb 29, 2024
@ocaisa ocaisa merged commit 2e07959 into easybuilders:develop Feb 29, 2024
5 checks passed
@Flamefire Flamefire deleted the 20231024153828_new_pr_GnuTLS372 branch March 1, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants