Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use %(sysroot)s template in wget easyconfigs to define PKG_CONFIG_PATH #19080

Merged
merged 2 commits into from
Oct 27, 2023
Merged

use %(sysroot)s template in wget easyconfigs to define PKG_CONFIG_PATH #19080

merged 2 commits into from
Oct 27, 2023

Conversation

xinan1911
Copy link
Contributor

(created using eb --new-pr)

@xinan1911
Copy link
Contributor Author

This pr depends on another pr in easybuild-framework easybuilders/easybuild-framework#4359.

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12058

Test results coming soon (I hope)...

- notification for comment with ID 1780658859 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/55f3383c28ba7b3e15ed9abeaf1ab86b for a full test report.

@xinan1911 xinan1911 changed the title generalize wget using sysroot template Generalize wget using sysroot template Oct 26, 2023
@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/d353d58ec68df8f62f4e02f594bde25d for a full test report.

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

@casparvl
Copy link
Contributor

N.B. I'm not testing the oldest wget's, those toolchains are deprecated anyway, and on my local system I couldn't build those toolchains anymore. Maybe that's also why generoso didn't return earlier with a result... hoping this works :)

@casparvl casparvl added the EESSI Related to EESSI project label Oct 26, 2023
@casparvl casparvl added this to the next release (4.8.2?) milestone Oct 26, 2023
@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12060

Test results coming soon (I hope)...

- notification for comment with ID 1781454402 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen2
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19080 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3648

Test results coming soon (I hope)...

- notification for comment with ID 1781532360 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@boegel
Copy link
Member

boegel commented Oct 27, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

@boegel boegel changed the title Generalize wget using sysroot template use sysroot template in wget easyconfigs to define PKG_CONFIG_PATH Oct 27, 2023
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19080 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3649

Test results coming soon (I hope)...

- notification for comment with ID 1782378584 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/6d286dfc89df929075e5aacc78542488 for a full test report.

boegel
boegel approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 27, 2023

I've verified that this works in the EESSI build environment as intended 👍

@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@boegel
Copy link
Member

boegel commented Oct 27, 2023

@boegelbot please test @ generoso
EB_ARGS="wget-1.20.1-GCCcore-7.3.0.eb wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb "

@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-7.3.0.eb wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb " EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12065

Test results coming soon (I hope)...

- notification for comment with ID 1782422633 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Oct 27, 2023

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/920f21f8aebce17bf1fe6f5f40d013c7 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/abc218a2f337a7c6e306d078d7732993 for a full test report.

@boegel boegel mentioned this pull request Oct 27, 2023
Merged
@boegel
Copy link
Member

boegel commented Oct 27, 2023

Going in, thanks @xinan1911!

@boegel boegel merged commit af1ba41 into easybuilders:develop Oct 27, 2023
5 checks passed
@boegel boegel added the bug fix label Oct 29, 2023
@boegel boegel changed the title use sysroot template in wget easyconfigs to define PKG_CONFIG_PATH use %(sysroot)s template in wget easyconfigs to define PKG_CONFIG_PATH Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Milestone
4.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@xinan1911 @casparvl @boegelbot @boegel