Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix [cz]asums in OpenBLAS 0.3.24 #19331

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)
This PR adds the patch OpenMathLib/OpenBLAS#4326 from @bartoldeman to fix [cz]asum. Without the patch 55 LAPACK test failurs can be observed. I noticed this on a Intel Sapphire Rapids system.

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bwd-rockylinux-93 - Linux Rocky Linux 9.3 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.129.03, Python 3.9.18
See https://gist.github.com/SebastianAchilles/28bac7a611a6b25b2659f4ff20e0ec49 for a full test report.

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrc0880.jureca - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Platinum 8452Y (sapphirerapids), 4 x NVIDIA NVIDIA H100 PCIe, 535.104.12, Python 3.6.8
See https://gist.github.com/SebastianAchilles/1c847b991aff950fb3e4c6dd63957ea4 for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19331 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19331 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3820

Test results coming soon (I hope)...

- notification for comment with ID 1829681522 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0c3a5996dbcbe9adad15c36fe9b82cd5 for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=19331 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19331 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12282

Test results coming soon (I hope)...

- notification for comment with ID 1829697868 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bartoldeman
Copy link
Contributor

In this case, while the patch doesn't hurt, it would be better to enable the avx512 microkernel on sapphire rapids.
OpenMathLib/OpenBLAS#4287
that microkernel is buggy for LLVM-based compilers (Intel/NVHPC), that was fixed in OpenMathLib/OpenBLAS#4330, though for GCC that doesn't matter here.

@SebastianAchilles
Copy link
Member Author

In this case, while the patch doesn't hurt, it would be better to enable the avx512 microkernel on sapphire rapids. OpenMathLib/OpenBLAS#4287 that microkernel is buggy for LLVM-based compilers (Intel/NVHPC), that was fixed in OpenMathLib/OpenBLAS#4330, though for GCC that doesn't matter here.

Good point. The patch OpenMathLib/OpenBLAS#4287 was already added in #19159 Using that patch building OpenBLAS for me on Sapphire Rapids.

@boegel
Copy link
Member

boegel commented Dec 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19331 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19331 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12326

Test results coming soon (I hope)...

- notification for comment with ID 1842581323 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/354d3618217cd932241e852b6414d44b for a full test report.

@boegel
Copy link
Member

boegel commented Dec 6, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3119.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/89b41ed04dcb7ae521aa9db106cd7218 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 6, 2023

Going in, thanks @SebastianAchilles!

@boegel boegel merged commit b4964d0 into easybuilders:develop Dec 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants