Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix easyconfigs for recent versions of QuantumESPRESSO #20070

Merged

Conversation

@ocaisa ocaisa added this to the release after 4.9.0 milestone Mar 8, 2024
Micket
Micket previously requested changes Mar 20, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024
@ocaisa ocaisa changed the title Correct configuration of QuantumESPRESSO for 6.7/7.2 Correct configuration of QuantumESPRESSO for 6.7/7.2/7.3, move all QE easyconfigs to "legacy" easyblock Apr 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Apr 14, 2024
@easybuilders easybuilders deleted a comment from boegelbot Apr 14, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d8f4707ab3d468d8c14f9dd9eec14029 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Jun 14, 2024

@boegel This is now succeeding for all easyconfigs in the PR except QuantumESPRESSO-7.0-intel-2021b.eb which seems to be totally broken, I have no fix for that so I am just going to remove it from the PR and pretend I didn't notice

It's making this PR look like there are problems where in reality this was always broken. Excluding it to get this over the line
@ocaisa
Copy link
Member Author

ocaisa commented Jun 14, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4388

Test results coming soon (I hope)...

- notification for comment with ID 2167955656 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Jun 14, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13744

Test results coming soon (I hope)...

- notification for comment with ID 2167965286 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/4a017aeb3c3b615107383c6274416798 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
FAILED
Build succeeded for 7 out of 9 (9 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5de0231b8d5d9761c19ef35213f69bd9 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 16, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13933

Test results coming soon (I hope)...

- notification for comment with ID 2231208018 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Jul 16, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4569

Test results coming soon (I hope)...

- notification for comment with ID 2231214045 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/2fef031bd61c8697f074c95ecb8bceae for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
FAILED
Build succeeded for 7 out of 9 (9 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/481f578c8f7ebc01bd3a0ddc6c05da02 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 22, 2024

There are cases where there are a significant number of test failures in old QE easyconfigs. The test suite was never run in the past so these were not caught. With the merge of easybuilders/easybuild-easyblocks#3338 I've explicitly skipped the test step for these cases.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 22, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4575

Test results coming soon (I hope)...

- notification for comment with ID 2242874569 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Jul 22, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3338"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20070 EB_ARGS="--include-easyblocks-from-pr 3338" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20070 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13941

Test results coming soon (I hope)...

- notification for comment with ID 2242895811 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Jul 23, 2024

The failures here are related to errors building the required dependencies with Intel (affects one ec in the PR, nothing wrong with the actual PR)

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
FAILED
Build succeeded for 11 out of 19 (12 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/b9a5eb8739be00570c0b07c28f2161f4 for a full test report.

@boegelbot
Copy link
Collaborator

boegelbot commented Jul 23, 2024

There is a single failure here because there is a lock file for the ec version that I do not have the power to remove

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3338
FAILED
Build succeeded for 11 out of 12 (12 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e5e4b0800b7075c7583bb6bb2ca3eeed for a full test report.

@ocaisa ocaisa changed the title Correct configuration of QuantumESPRESSO for 6.7/6.8/7.0/7.2/7.3 Correct configuration of QuantumESPRESSO for 6.7/6.8/7.0/7.1/7.2/7.3 Jul 23, 2024
@jfgrimm jfgrimm merged commit 1a2fe8a into easybuilders:develop Jul 23, 2024
9 checks passed
@ocaisa ocaisa deleted the 20240308101931_new_pr_QuantumESPRESSO67 branch July 23, 2024 16:03
@boegel boegel changed the title Correct configuration of QuantumESPRESSO for 6.7/6.8/7.0/7.1/7.2/7.3 fix easyconfigs for recent versions of QuantumESPRESSO Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants