-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{ai}[foss/2023a] Slideflow v3.0.1 w/ CUDA 12.1.1 #20857
{ai}[foss/2023a] Slideflow v3.0.1 w/ CUDA 12.1.1 #20857
Conversation
Test report by @lcniel |
easybuild/easyconfigs/s/Slideflow/Slideflow-2.3.1-foss-2023a-CUDA-12.1.1.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/s/Slideflow/Slideflow-2.3.1-foss-2023a-CUDA-12.1.1.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/s/Slideflow/Slideflow-2.3.1-foss-2023a-CUDA-12.1.1.eb
Outdated
Show resolved
Hide resolved
…UDA-12.1.1.eb Co-authored-by: Mikael Öhman <[email protected]>
…UDA-12.1.1.eb Co-authored-by: Mikael Öhman <[email protected]>
Test report by @lcniel |
…asyconfigs into 20240619151046_new_pr_Slideflow231
@Micket I will do an additional test build just to be sure. |
Test report by @lcniel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have pandas and seaborn in easyconfigs already, do we have specific version requirements that neccesitates this?
For this version, yes. It seems like due to a ticket opened by me, they later released a patch that makes it compatible with pandas 2+. It seems like bumping the Slideflow version up would also allow a more recent Seaborn version to be used. So that's an option, but then we might break other dependencies. I will give it a try I suppose. |
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2388494069 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
OK, looks like I need to manually redo the patch, I need to wait for my build to finish so I can make sure the path is correct. |
Test report by @lcniel |
This takes care of patch issue, rebuilding Slideflow itself to verify that there are no other problems. |
Test report by @lcniel |
Test report by @lcniel |
Test report by @lcniel |
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2390639971 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
easybuild/easyconfigs/s/Slideflow/Slideflow-3.0.1-foss-2023a-CUDA-12.1.1.eb
Outdated
Show resolved
Hide resolved
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2390683890 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Is this an automated testing issue? I can't see why it wouldn't find the patch... |
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2390750672 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@Micket Looks like an error with the runner itself, maybe a rerun of that particular test is enough? Something to open an issue about maybe.
|
…asyconfigs into 20240619151046_new_pr_Slideflow231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick
easybuild/easyconfigs/s/Slideflow/Slideflow-3.0.1-foss-2023a-CUDA-12.1.1.eb
Outdated
Show resolved
Hide resolved
…UDA-12.1.1.eb Co-authored-by: Jasper Grimm <[email protected]>
@boegelbot please test @ jsc-zen3 |
@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2391029410 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @lcniel! |
Test report by @jfgrimm |
(created using
eb --new-pr
)Requires #20853 #20854