Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ai}[foss/2023a] Slideflow v3.0.1 w/ CUDA 12.1.1 #20857

Merged

Conversation

lcniel
Copy link
Contributor

@lcniel lcniel commented Jun 19, 2024

(created using eb --new-pr)

Requires #20853 #20854

@lcniel
Copy link
Contributor Author

lcniel commented Jun 19, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
vera14-4 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/3883036510c815e8d7b0ece3bf240b9c for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Sep 16, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 52 out of 52 (1 easyconfigs in total)
alvis6-06 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A40, 550.54.14, Python 3.6.8
See https://gist.github.com/lcniel/8125444628d51ea74bed17476c1bb8c0 for a full test report.

@lcniel lcniel requested a review from Micket September 30, 2024 15:49
@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

@Micket I will do an additional test build just to be sure.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 33 out of 33 (1 easyconfigs in total)
alvis2-07 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 1 x NVIDIA Tesla T4, 560.35.03, Python 3.6.8
See https://gist.github.com/lcniel/1572d4ea2381c45f4af53628f0b833c7 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have pandas and seaborn in easyconfigs already, do we have specific version requirements that neccesitates this?

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

We do have pandas and seaborn in easyconfigs already, do we have specific version requirements that neccesitates this?

For this version, yes. It seems like due to a ticket opened by me, they later released a patch that makes it compatible with pandas 2+.

It seems like bumping the Slideflow version up would also allow a more recent Seaborn version to be used. So that's an option, but then we might break other dependencies. I will give it a try I suppose.

@Micket Micket changed the title {ai}[foss/2023a] Slideflow v2.3.1 w/ CUDA 12.1.1 {ai}[foss/2023a] Slideflow v3.0.1 w/ CUDA 12.1.1 Oct 2, 2024
@Micket Micket added the new label Oct 2, 2024
@Micket Micket added this to the release after 4.9.4 milestone Oct 2, 2024
@Micket
Copy link
Contributor

Micket commented Oct 2, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4971

Test results coming soon (I hope)...

- notification for comment with ID 2388494069 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/2c6d1aaefa21aeb11ccc23577ca94943 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

OK, looks like I need to manually redo the patch, I need to wait for my build to finish so I can make sure the path is correct.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

Test report by @lcniel
FAILED
Build succeeded for 31 out of 32 (1 easyconfigs in total)
alvis2-18 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 8 x NVIDIA Tesla T4, 560.35.03, Python 3.6.8
See https://gist.github.com/lcniel/88ef3df203c197c423c971b697b21a9f for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

This takes care of patch issue, rebuilding Slideflow itself to verify that there are no other problems.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis2-18 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 8 x NVIDIA Tesla T4, 560.35.03, Python 3.6.8
See https://gist.github.com/lcniel/7239bf28e98d2849857af4992838474f for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis2-18 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 8 x NVIDIA Tesla T4, 560.35.03, Python 3.6.8
See https://gist.github.com/lcniel/392e9d101dd497ffdf04a6bb70c14c2b for a full test report.

@lcniel lcniel requested a review from Micket October 2, 2024 14:57
@lcniel
Copy link
Contributor Author

lcniel commented Oct 2, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 32 out of 32 (1 easyconfigs in total)
alvis3-25 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/lcniel/676ba201240384872162daf7ee32931e for a full test report.

@Micket
Copy link
Contributor

Micket commented Oct 3, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4974

Test results coming soon (I hope)...

- notification for comment with ID 2390639971 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a920a62b3f95efec74c480dc9ef80dc3 for a full test report.

@Micket
Copy link
Contributor

Micket commented Oct 3, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--force-download=all"

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20857 EB_ARGS="--force-download=all" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4975

Test results coming soon (I hope)...

- notification for comment with ID 2390683890 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/e7e229e08679bda198eaa20ce8d9a2e4 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Oct 3, 2024

Is this an automated testing issue? I can't see why it wouldn't find the patch...

@Micket
Copy link
Contributor

Micket commented Oct 3, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--force-download=sources"

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20857 EB_ARGS="--force-download=sources" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4976

Test results coming soon (I hope)...

- notification for comment with ID 2390750672 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/3498f63cd777268fe75c790dc294070d for a full test report.

@Micket Micket enabled auto-merge October 3, 2024 08:35
@lcniel
Copy link
Contributor Author

lcniel commented Oct 3, 2024

@Micket Looks like an error with the runner itself, maybe a rerun of that particular test is enough? Something to open an issue about maybe.

== FAILED: Installation ended unsuccessfully (build directory: /tmp/runner/bcc6e402a898cc3f8887b9b422794e372cb39053/build/M4/1.4.18/system-system): build failed (first 300 chars): Unexpected error occurred when trying to download https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=59e2ce0e6b46bb47ef81b68b600ed087e14fdaad to /tmp/sources/generic/eb_v4.9.5.dev0/ConfigureMake/config.guess: 'Failed to write to /tmp/sources/generic/eb_v4.9.5.dev0/Confi (took 23 secs)
== Results of the build can be found in the log file(s) /tmp/eb-3x1llh4w/easybuild-M4-1.4.18-20241003.085715.flbHz.log

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick

@jfgrimm jfgrimm dismissed Micket’s stale review October 3, 2024 09:59

req changes made

@jfgrimm jfgrimm disabled auto-merge October 3, 2024 10:05
@jfgrimm
Copy link
Member

jfgrimm commented Oct 3, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20857 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20857 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4982

Test results coming soon (I hope)...

- notification for comment with ID 2391029410 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/29f94b92ebe50487d996371d9b21fb14 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Oct 3, 2024

Going in, thanks @lcniel!

@jfgrimm jfgrimm merged commit ef56e11 into easybuilders:develop Oct 3, 2024
9 checks passed
@jfgrimm
Copy link
Member

jfgrimm commented Oct 3, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 17 out of 17 (1 easyconfigs in total)
gpu26.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7413 24-Core Processor, 1 x NVIDIA NVIDIA H100 PCIe, 535.161.08, Python 3.6.8
See https://gist.github.com/jfgrimm/2a40a8edd1e09927980d0bb7182a32a9 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants